[CI] Add "loader" support to conformance testing #2082
Conversation
RossBrunton
force-pushed
the
ross/multiadapt
branch
from
7f5f4dc
to
37b9c8a
Compare
RossBrunton
force-pushed
the
ross/multiadapt
branch
from
37b9c8a
to
b311697
Compare
RossBrunton
force-pushed
the
ross/multiadapt
branch
3 times, most recently
from
765d74d
to
1a590df
Compare
RossBrunton
force-pushed
the
ross/multiadapt
branch
7 times, most recently
from
43feaa2
to
6b30976
Compare
RossBrunton
changed the title
RossBrunton
force-pushed
the
ross/multiadapt
branch
9 times, most recently
from
23ec456
to
c26d47e
Compare
RossBrunton
force-pushed
the
ross/multiadapt
branch
from
c26d47e
to
0193d8e
Compare
github-actions
bot
added
the
specification
RossBrunton
force-pushed
the
ross/multiadapt
branch
3 times, most recently
from
1c51ebc
to
5901769
Compare
RossBrunton
force-pushed
the
ross/multiadapt
branch
3 times, most recently
from
d147c8f
to
1503e67
Compare
RossBrunton
force-pushed
the
ross/multiadapt
branch
9 times, most recently
from
fd9b9ef
to
74eaf70
Compare
RossBrunton
force-pushed
the
ross/multiadapt
branch
3 times, most recently
from
6f75bec
to
29f5904
Compare
.github/workflows/cmake.yml
Outdated
| @@ -187,6 +187,24 @@ jobs: | |||
| adapter_name: NATIVE_CPU | |||
| runner_name: NATIVE_CPU | |||
|
|
|||
| # Native CPU jobs are here to force the loader to be used | |||
There was a problem hiding this comment.
Is there value in testing the loader with CUDA/HIP? It would use more CI resources but might catch more issues.
| @@ -0,0 +1,3 @@ | |||
| # Note: This file is only for use with cts_exe.py | |||
There was a problem hiding this comment.
I might be wrong but shouldn't this note be true for all match files, and if so, I don't think we need to add this note.
There was a problem hiding this comment.
There are two programs now that handle match files; the older matching logic and cts_exe.py. When I updated the files, I did so in a way incompatible with the old match checker thing. Figured I'd add a note calling that out.
Although, happy to remove it now that we've transitioned to using cts_exe.py.
There was a problem hiding this comment.
Ah okay make sense, I think it is better to keep it for now to avoid confusion then with the old matching logic. might be worth also calling out explicitly that this is incompatible with the old matching system. (doesn't have strong opinions about this)
There was a problem hiding this comment.
#2285 Decided to go hard in the other direction. Drop support for the older matching logic and make our testing files look neater. Not sure how popular a change this will be though.
RossBrunton
force-pushed
the
ross/multiadapt
branch
from
29f5904
to
60d53ec
Compare
This expands our CI to test the loader; the dispatcher that is used when multiple adapters are availabe. The old "run on hardware" jobs should behave the same (they have the loader tests disabled), but there are new "combined" jobs with OpenCL/Level Zero + Native CPU. Closes: oneapi-src#2081
RossBrunton
force-pushed
the
ross/multiadapt
branch
from
60d53ec
to
0b96866
Compare
|
Merging without LLVM change, as this only affects our testing. |
This expands our CI to test the loader; the dispatcher that is
used when multiple adapters are available.
The old "run on hardware" jobs should behave the same (they have
the loader tests disabled), but there are new "combined" jobs
with OpenCL/Level Zero + Native CPU.
Closes: #2081