Event wait test #2040
Open
Event wait test #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ci/cd
pbalcer
approved these changes
Sep 9, 2024
test/conformance/enqueue/urEnqueueKernelLaunchAndMemcpyInOrder.cpp
Outdated
Show resolved
Hide resolved
igchor
force-pushed
the
event_wait_test
branch
2 times, most recently
from
041f510
to
349d5a5
Compare
Rebased. |
pbalcer
force-pushed
the
event_wait_test
branch
from
349d5a5
to
ab537af
Compare
pbalcer
reviewed
Sep 17, 2024
| // are completed | ||
| urQueueFinish(queues.back()); | ||
| if (waitOnEvent) { |
There was a problem hiding this comment.
since the 'background check' function waits for its threads to finish, this is guaranteed to have been completed already. Was that intentional? That'd be odd for an event wait test :)
| @@ -265,14 +316,15 @@ TEST_F(urEnqueueKernelLaunchIncrementMultiDeviceTest, Success) { | |||
| constexpr size_t global_offset = 0; | |||
| constexpr size_t n_dimensions = 1; | |||
|
|
|||
| std::vector<uur::raii::Event> Events(devices.size() * 2); | |||
| std::vector<uur::raii::Event> Events(devices.size() * 2 - 1); | |||
There was a problem hiding this comment.
This is going to be fragile and difficult to modify. I get what you are trying to do, but I suggest we try avoiding too match pointer arithmetic.
Can you just create two vectors?
| Events[i * 2].get(), | ||
| UR_EVENT_INFO_COMMAND_EXECUTION_STATUS, | ||
| sizeof(ur_event_status_t), &status, nullptr)); | ||
| } while (status != UR_EVENT_STATUS_COMPLETE); |
There was a problem hiding this comment.
maybe sleep for a few miliseconds every iteration?
| @@ -189,7 +213,7 @@ TEST_P(urEnqueueKernelLaunchIncrementTest, Success) { | |||
|
|
|||
| auto useEvents = std::get<1>(GetParam()).value; | |||
|
|
|||
| std::vector<uur::raii::Event> Events(numOps * 2); | |||
| std::vector<uur::raii::Event> Events(numOps * 2 - 1); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.