Merge pull request #1821 from PietroGhg/pietro/native_cpu_specconstants

[NATIVECPU] Initial support for spec constants on Native CPU
oneapi-src · Sep 13, 2024 · fa9ebe7 · fa9ebe7
2 parents 92638b2 + 9eb1c74
commit fa9ebe7
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 9 deletions.
diff --git a/source/adapters/native_cpu/device.cpp b/source/adapters/native_cpu/device.cpp
@@ -160,9 +160,9 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
   case UR_DEVICE_INFO_VERSION:
     return ReturnValue("0.1");
   case UR_DEVICE_INFO_COMPILER_AVAILABLE:
-    return ReturnValue(bool{false});
+    return ReturnValue(bool{true});
   case UR_DEVICE_INFO_LINKER_AVAILABLE:
-    return ReturnValue(bool{false});
+    return ReturnValue(bool{true});
   case UR_DEVICE_INFO_MAX_COMPUTE_UNITS:
     return ReturnValue(static_cast<uint32_t>(hDevice->tp.num_threads()));
   case UR_DEVICE_INFO_PARTITION_MAX_SUB_DEVICES:

diff --git a/source/adapters/native_cpu/memory.cpp b/source/adapters/native_cpu/memory.cpp
@@ -46,7 +46,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urMemBufferCreate(
   UR_ASSERT(size != 0, UR_RESULT_ERROR_INVALID_BUFFER_SIZE);
 
   const bool useHostPtr = flags & UR_MEM_FLAG_USE_HOST_POINTER;
-  const bool copyHostPtr = flags & UR_MEM_FLAG_USE_HOST_POINTER;
+  const bool copyHostPtr = flags & UR_MEM_FLAG_ALLOC_COPY_HOST_POINTER;
 
   ur_mem_handle_t_ *retMem;
 

diff --git a/source/adapters/native_cpu/platform.cpp b/source/adapters/native_cpu/platform.cpp
@@ -92,7 +92,17 @@ UR_APIEXPORT ur_result_t UR_APICALL urPlatformGetBackendOption(
   std::ignore = pFrontendOption;
   std::ignore = ppPlatformOption;
 
-  CONTINUE_NO_IMPLEMENTATION;
+  std::ignore = hPlatform;
+  using namespace std::literals;
+  if (pFrontendOption == nullptr)
+    return UR_RESULT_ERROR_INVALID_NULL_POINTER;
+  if (pFrontendOption == "-O0"sv || pFrontendOption == "-O1"sv ||
+      pFrontendOption == "-O2"sv || pFrontendOption == "-O3"sv ||
+      pFrontendOption == ""sv) {
+    *ppPlatformOption = "";
+    return UR_RESULT_SUCCESS;
+  }
+  return UR_RESULT_ERROR_INVALID_VALUE;
 }
 
 UR_APIEXPORT ur_result_t UR_APICALL urPlatformCreateWithNativeHandle(

diff --git a/test/conformance/platform/platform_adapter_native_cpu.match b/test/conformance/platform/platform_adapter_native_cpu.match
@@ -1,6 +1 @@
 urPlatformCreateWithNativeHandleTest.InvalidNullPointerPlatform
-urPlatfromGetBackendOptionTest.InvalidValueFrontendOption
-urPlatfromGetBackendOptionTestWithParam.Success/_O0
-urPlatfromGetBackendOptionTestWithParam.Success/_O1
-urPlatfromGetBackendOptionTestWithParam.Success/_O2
-urPlatfromGetBackendOptionTestWithParam.Success/_O3