Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] add a few missing template keywords #1447

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[NFC] add a few missing template keywords #1447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01f94b2
[NFC] add a few missing template keywords
kedartal Jul 12, 2024
a00d6c9
[NFC] template keyword only for clang >= 19
kedartal Jul 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions include/oneapi/tbb/detail/_flow_graph_node_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,11 @@ class function_input_queue : public item_buffer<T,A> {
}

const T& front() const {
#if defined( __clang__ ) && __clang_major__ >= 19
return this->template item_buffer<T, A>::front();
#else
return this->item_buffer<T, A>::front();
#endif
}

void pop() {
Expand Down
8 changes: 8 additions & 0 deletions include/oneapi/tbb/enumerable_thread_specific.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -879,7 +879,11 @@ class enumerable_thread_specific: ets_base<ETS_key_type> {
~enumerable_thread_specific() {
if(my_construct_callback) my_construct_callback->destroy();
// Deallocate the hash table before overridden free_array() becomes inaccessible
#if defined( __clang__ ) && __clang_major__ >= 19
this->template ets_base<ETS_key_type>::table_clear();
#else
this->ets_base<ETS_key_type>::table_clear();
#endif
}

//! returns reference to local, discarding exists
Expand Down Expand Up @@ -943,7 +947,11 @@ class enumerable_thread_specific: ets_base<ETS_key_type> {
// concurrent_vector::swap() preserves storage space,
// so addresses to the vector kept in ETS hash table remain valid.
swap(my_locals, other.my_locals);
#if defined( __clang__ ) && __clang_major__ >= 19
this->template ets_base<ETS_key_type>::table_swap(other);
#else
this->ets_base<ETS_key_type>::table_swap(other);
#endif
}

template<typename A2, ets_key_usage_type C2>
Expand Down
Loading