Skip to content

Commit

Permalink
removed unnecessary condition from gh action
Browse files Browse the repository at this point in the history
  • Loading branch information
onderonur committed Aug 18, 2024
1 parent 3144dfb commit cf3aac3
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
2 changes: 1 addition & 1 deletion .github/composite-actions/install/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ runs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 20
node-version-file: '.nvmrc'
cache: npm

- name: Install dependencies
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/nextjs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,6 @@ jobs:

# Deployment job
deploy:
# Since `workflow_run` only has 3 activity types (`completed`, `requested` and `in_progress`),
# even if `Quality` workflow gets completed by failing, this workflow starts to run.
# To prevent this, we add a condition here.
# https://github.com/orgs/community/discussions/26238#discussioncomment-3250901
if: ${{ github.event.workflow_run.conclusion == 'success' }}
environment:
name: github-pages
url: ${{ steps.deployment.outputs.page_url }}
Expand Down

0 comments on commit cf3aac3

Please sign in to comment.