MDA Lite Reporting #1536

ciremusyoka · 2021-03-18T14:40:15Z

Part of #1494
Adds following views:

MDA Lite plans list view
Jurisdictions report view (From country level to ward level)
Ward supervisors report view
CDDs under a particular supervisor report view
Wards map view

… supervisor reporting page

coveralls · 2021-04-09T06:33:04Z

Coverage increased (+0.1%) to 90.71% when pulling bf55e0f on endfund-reports into 7d8945e on master.

kelvin-muchiri · 2021-04-12T09:39:49Z

src/components/page/Header/index.tsx

@@ -288,6 +292,20 @@ export class HeaderComponent extends React.Component<HeaderProps, State> {
                        </DropdownItem>
                      </div>
                    )}
+
+                    {ENABLE_MDA_LITE && (


Does the enable/disable also work at the route level? i.e Can you access the route if the menu link is disabled?

Yeah the link will be accessible. Fixing that.

@kelvin-muchiri this is affecting all routes in reveal and have created an issue here to address it.

kelvin-muchiri · 2021-04-12T09:42:52Z

src/containers/pages/GenericJurisdictionReport/helpers.ts

+/** columns for mda Lite jurisdictions */
+export const genderReportColumns = [
+  {
+    Header: 'Male',


Do we need to have this translated? plus the rest of the table columns

kelvin-muchiri · 2021-04-12T09:49:01Z

src/containers/pages/MDALite/cddReports/cdds.tsx

+    return <Loading />;
+  }
+  return (
+    <div>


Would it be better to use React fragment <>...</> in this particular case instead of <div>....</div>

kelvin-muchiri · 2021-04-12T09:54:11Z

src/containers/pages/MDALite/cddReports/cdds.tsx

+  const tableProps = getCddTableProps(cddReportColumns, cddData, props);
+
+  if (loading) {
+    return <Loading />;


Shouldn't we have this piece of code above the code that precedes it. i.e Why should we execute code then check for the loading status? In a case where loading is false, all that execution would be futile

kelvin-muchiri · 2021-04-12T09:55:13Z

src/containers/pages/MDALite/cddReports/helpers.tsx

+      const url = `${REPORT_MDA_LITE_CDD_REPORT_URL}/${original.plan_id}/${original.base_entity_id}/${original.id}`;
+      return <Link to={url}>{cell.value}</Link>;
+    },
+    Header: 'Name',


Do we need to translate this table column?

kelvin-muchiri · 2021-04-12T09:55:36Z

src/containers/pages/MDALite/cddReports/helpers.tsx

+/** CDD columns */
+export const cddReportColumns = [
+  {
+    Header: 'Name',


Do we need to translate these table columns?

kelvin-muchiri · 2021-04-12T09:57:00Z

src/containers/pages/MDALite/cddReports/supervisors.tsx

+  // table props
+  const tableProps = getCddTableProps(supervisorColumns, supervisorData, props);
+
+  if (loading) {


Shouldn't we have this piece of code above the code that precedes it. i.e Why should we execute code then check for the loading status? In a case where loading is false, all that execution would be futile

kelvin-muchiri · 2021-04-12T09:59:42Z

src/containers/pages/MDALite/jurisdictionsReport/index.tsx

+  props: GenericJurisdictionProps & RouteComponentProps<RouteParams>
+) => {
+  return (
+    <div>


Would it be better to use react fragment instead of div?

kelvin-muchiri · 2021-04-12T10:03:03Z

src/containers/pages/MDALite/wardReports/helpers.tsx

+      const url = `${REPORT_MDA_LITE_CDD_REPORT_URL}/${original.plan_id}/${original.base_entity_id}`;
+      return <Link to={url}>{cell.value}</Link>;
+    },
+    Header: 'Name',


do we need to translate the column name?

peterMuriuki

LGTM

peterMuriuki · 2021-04-12T12:08:51Z

src/containers/pages/MDALite/map/index.tsx

+reducerRegistry.register(genericPlanReducerName, GenericPlansReducer);
+reducerRegistry.register(genericStructuresReducerName, genericStructuresReducer);
+
+/** selectors */


hanging comment.

src/containers/pages/MDALite/map/index.tsx

peterMuriuki · 2021-04-12T12:21:54Z

src/containers/pages/MDALite/plans/tests/__snapshots__/index.test.tsx.snap

+Object {
+  "fetchPlans": [Function],
+  "history": Object {


i am more of the opinion that we should use equality assertions for things like prop checks as opposed to snapshots.

src/containers/pages/MDALite/wardReports/index.tsx

Naima-Bashir · 2021-04-19T08:51:24Z

#1554
bug

ciremusyoka added 23 commits March 9, 2021 11:17

Add MDA-Lite plans reporting page

f0c0b16

Document and add envs to sample file

edb4a4c

Add MDA-Lite jurisdictions reporting view

07b3be6

Document and add MDA-Lite jurisdiction reporting envs to sample file

5a42291

Group MDA-Lite columns

63fb63d

Merge branch 'master' into branch 'endfund-reports'

a616020

Add MDA-Lite jurisdiction reporting column accessors

e7ac908

Add Component for formating the drill down links

512771c

MDA-Lite add ward level columns

0be6c2f

Change color of returned to supervisor if less than remaining with CDD

1692382

Add MDA-Lite CDD and Supervisor report columns

0735233

MDA-Lite add CDD reporting page

336d82e

MDA-Lite CDD reports get drillDownTable props from a function and add…

f7524b6

… supervisor reporting page

Clean up

5d373c3

Add MDA-Lite CDDs reducer and actions

d4846d3

Add MDA-Lite supervisors reducer and actions

a42729d

Connect MDA-Lite CDD report component with store

7160355

MDA-Lite connect Supervisor reports component to store

00cedc8

Clean up and create links for CDD and supervisor views

89d207e

Fix tests failling after add MDA-lite Reports

43c6652

Add MDA-Lite plans tests

33b6d6d

Add MDA-Lite jurisdictions report fixtures

6e12096

Add MDA-Lite jurisdiction reports tests

1aaae84

ciremusyoka added the WIP Work in Progress label Mar 18, 2021

ciremusyoka self-assigned this Mar 18, 2021

ciremusyoka added 5 commits April 7, 2021 11:26

Update CDDs columns

95b7ea3

Add MDA Lite wards reducer

396c6db

Add MDA Lite wards report page

9a6a143

Link all MDA Lite views correctly

29ed5ef

Add MDA Lite Map component

b98abb4

ciremusyoka added 2 commits April 8, 2021 21:51

Add MDA Lite CDDs reducre test

e2dadba

Add MDA Lite CDDs report page test

b26f1f3

ciremusyoka removed the WIP Work in Progress label Apr 9, 2021

ciremusyoka requested review from moshthepitt, haseemVD, kelvin-muchiri and peterMuriuki April 9, 2021 06:47

ciremusyoka added 2 commits April 9, 2021 09:48

Clean up

c814575

Marge branch 'master' into branch 'endfund_reports'

adb6626

kelvin-muchiri reviewed Apr 12, 2021

View reviewed changes

peterMuriuki reviewed Apr 12, 2021

View reviewed changes

ciremusyoka added 4 commits April 12, 2021 19:41

Translate MDA Lite table headers

f2b2183

Clean up: Update comments and remove unused code

5ba8756

Tests use equality assertions instead of snapshot

3a8babe

Translate missed string

bf55e0f

peterMuriuki approved these changes Apr 13, 2021

View reviewed changes

kelvin-muchiri approved these changes Apr 13, 2021

View reviewed changes

peterMuriuki merged commit c1c2bf2 into master Apr 13, 2021

peterMuriuki deleted the endfund-reports branch April 13, 2021 09:55

Naima-Bashir added the QA- Failed QA label Apr 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MDA Lite Reporting #1536

MDA Lite Reporting #1536

ciremusyoka commented Mar 18, 2021 •

edited

Loading

coveralls commented Apr 9, 2021 •

edited

Loading

kelvin-muchiri Apr 12, 2021

ciremusyoka Apr 12, 2021

ciremusyoka Apr 13, 2021

kelvin-muchiri Apr 12, 2021 •

edited

Loading

kelvin-muchiri Apr 12, 2021

kelvin-muchiri Apr 12, 2021

kelvin-muchiri Apr 12, 2021

kelvin-muchiri Apr 12, 2021 •

edited

Loading

kelvin-muchiri Apr 12, 2021

kelvin-muchiri Apr 12, 2021

kelvin-muchiri Apr 12, 2021

peterMuriuki left a comment •

edited

Loading

peterMuriuki Apr 12, 2021

peterMuriuki Apr 12, 2021

Naima-Bashir commented Apr 19, 2021 •

edited

Loading

MDA Lite Reporting #1536

MDA Lite Reporting #1536

Conversation

ciremusyoka commented Mar 18, 2021 • edited Loading

coveralls commented Apr 9, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kelvin-muchiri Apr 12, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kelvin-muchiri Apr 12, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peterMuriuki left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Naima-Bashir commented Apr 19, 2021 • edited Loading

ciremusyoka commented Mar 18, 2021 •

edited

Loading

coveralls commented Apr 9, 2021 •

edited

Loading

kelvin-muchiri Apr 12, 2021 •

edited

Loading

kelvin-muchiri Apr 12, 2021 •

edited

Loading

peterMuriuki left a comment •

edited

Loading

Naima-Bashir commented Apr 19, 2021 •

edited

Loading