Optimize location hierarchy #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
=============================================
+ Coverage 44.25% 60.89% +16.64%
- Complexity 138 195 +57
=============================================
Files 16 16
Lines 1358 1404 +46
Branches 160 158 -2
=============================================
+ Hits 601 855 +254
+ Misses 689 468 -221
- Partials 68 81 +13 ☔ View full report in Codecov by Sentry. |
Instead of fetching entire practitionerdetails, just get the locations.
lincmba
force-pushed
the
optimize_location_hierarchy
branch
from
25c2248
to
ec06253
Compare
- replace for loops with streams - use sets instead of lists to avoid duplication - switch from using DFS to BFS in getting locations deep in the hierarchy
- switch from for loop to streams in filterLocationsByAdminLevels
lincmba
commented
Sep 27, 2024
| @@ -443,23 +453,25 @@ public List<String> generateAdminLevels( | |||
|
|
|||
| public List<Location> filterLocationsByAdminLevels( | |||
| List<Location> locations, List<String> postFetchAdminLevels) { | |||
| if (postFetchAdminLevels == null) { | |||
|
|
|||
| if (postFetchAdminLevels == null || postFetchAdminLevels.isEmpty()) { | |||
There was a problem hiding this comment.
Resolves bug of filtering out all locations when adminlevels is not provided/is empty
|
PR looks good. Lets bump up the Release version as well cc @lincmba |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #82
Engineer Checklist
bug fixes
option(s) on the
README.mdmvn spotless:checkto check my code follows the project'sstyle guide
mvn clean test jacoco:reportto confirm the coverage reportwas generated at
plugins/target/site/jacoco/index.htmlmvn clean packageright before creating this pull request.