Build LocationHierarchy Location hierarchy on sync strategy #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
============================================
+ Coverage 43.81% 45.01% +1.19%
- Complexity 106 130 +24
============================================
Files 15 16 +1
Lines 1075 1213 +138
Branches 120 146 +26
============================================
+ Hits 471 546 +75
- Misses 545 600 +55
- Partials 59 67 +8 ☔ View full report in Codecov by Sentry. |
...ns/src/main/java/org/smartregister/fhir/gateway/plugins/LocationHierarchyEndpointHelper.java
Outdated
Show resolved
Hide resolved
plugins/src/main/java/org/smartregister/fhir/gateway/plugins/PermissionAccessChecker.java
Outdated
Show resolved
Hide resolved
plugins/src/main/java/org/smartregister/fhir/gateway/plugins/PermissionAccessChecker.java
Outdated
Show resolved
Hide resolved
plugins/src/main/java/org/smartregister/fhir/gateway/plugins/PermissionAccessChecker.java
Outdated
Show resolved
Hide resolved
plugins/src/main/java/org/smartregister/fhir/gateway/plugins/PermissionAccessChecker.java
Outdated
Show resolved
Hide resolved
...ns/src/main/java/org/smartregister/fhir/gateway/plugins/LocationHierarchyEndpointHelper.java
Outdated
Show resolved
Hide resolved
| @@ -161,7 +161,7 @@ public Bundle handleNonIdentifierRequest( | |||
| List<String> selectedSyncLocations = extractSyncLocations(syncLocationsParam); | |||
| String practitionerId = verifiedJwt.getSubject(); | |||
| List<String> userRoles = JwtUtils.getUserRolesFromJWT(verifiedJwt); | |||
| String syncStrategy = getSyncStrategy(verifiedJwt); | |||
| String syncStrategy = getSyncStrategyFromJwtToken(verifiedJwt); | |||
There was a problem hiding this comment.
Nit pick (maybe) - I think we should have the method pass in the application id as parameter since conceptually we usually map an application id to a sync id.
Then call it something like like getSyncStrategyByAppId(
lincmba
force-pushed
the
location_hierarchy_on_sync_strategy
branch
from
6562718
to
1da65ba
Compare
ndegwamartin
previously approved these changes
Jul 16, 2024
dubdabasoduba
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #65
Engineer Checklist
bug fixes
option(s) on the
README.mdmvn spotless:checkto check my code follows the project'sstyle guide
mvn clean test jacoco:reportto confirm the coverage reportwas generated at
plugins/target/site/jacoco/index.htmlmvn clean packageright before creating this pull request.