Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bind): support options in @sessionx-bind #127

Closed
wants to merge 3 commits into from

Conversation

znd4
Copy link

@znd4 znd4 commented Jul 21, 2024

I just learned from cmp-git that #7 already exists. I suppose this is an alternative solution for #85.

An example of using this would be

set -g @sessionx-bind '-n M-o'

I'll add an example to the README, and no hard feelings if you prefer #7

security concern?

I call out in the code comment that this is kind of intentionally having users inject code in a string input, but I can't imagine why anyone would put untrusted input here , so... 🤷 ?

@omerxx
Copy link
Owner

omerxx commented Sep 17, 2024

Hey @znd4 thank you for this! I just merged the previous approach, if you think there's a special advantage to your change please share it and lets discuss!
I'll close this for now but if you feel it's worth discussing and can improve the overall workflow / UX please re-open and lets chat!

@omerxx omerxx closed this Sep 17, 2024
@znd4 znd4 deleted the bind-options branch September 17, 2024 12:25
@znd4
Copy link
Author

znd4 commented Sep 17, 2024

No hard feelings, and thanks for these fun plugins and all of the great content!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants