Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apache common libs #436

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dominikl
Copy link
Member

I have no idea where the apache commons io dependency is defined. But lets see if this fixes #435

@jburel
Copy link
Member

jburel commented Apr 4, 2024

commons-io is injected in omero-server
There was an attempt to remove it see ome/omero-romio#14
I don't think we should add it
I think we should try to use nio Paths or Files. See for example #268 usage of toURI to solve a similar problem

@dominikl
Copy link
Member Author

dominikl commented Apr 4, 2024

Good idea. I'll try to remove it 👍

@dominikl
Copy link
Member Author

dominikl commented Apr 5, 2024

Actually, not a good idea. It's everywhere. I've tried got rid of it in Insight, but then failed at

with error: cannot access DirectoryWalker, icContainers = ic.getContainers(); I.e. it's heavily used in omero-blitz as well. You mentioned omero-romio... I guess it's in many many more. Which probably also means updating it to a new version is a pain.

@snoopycrimecop snoopycrimecop mentioned this pull request Sep 4, 2024
@dominikl
Copy link
Member Author

dominikl commented Sep 4, 2024

--exclude temporary exclude due to merge conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InvalidPathException: Illegal character [?] in path
2 participants