-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testSaneUsedFiles: check getCurrentFile is the first file in the getUsedFiles list #4172
testSaneUsedFiles: check getCurrentFile is the first file in the getUsedFiles list #4172
Conversation
2a60d54
to
ca66ec1
Compare
As expected, quite a few failures reported in the nightly CI builds. The reader for the following curated QA folders should likely be reviewed as a next step:
Marking this PR as draft in the meantime |
As discussed today, assigning to the |
c119d75
to
337cbef
Compare
…atch This approach will allow to incrementally work through each reader and re-include them in the getCurrentFile/getUsedFiles test
337cbef
to
0fc32a5
Compare
Updated the PR and the description to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense since, as discussed, the goal is to remove the reader format checks incrementally in follow-up PRs.
This would have been included in https://merge-ci.openmicroscopy.org/jenkins/job/BIOFORMATS-test-repo/244/, so merging.
From an discussion with @melissalinkert and @jburel, this was opening initially to assess how many formats deviate from this assumption in the nightly CI builds
FormatReaderTest.testSaneUsedFiles
is currently testing that the first item of IFormatReader.getUsedFiles() is equal to IFormatReader.getCurrentFile() for single-file formats.This change extends the test logic to assert this condition for all file formats manually excluding the 10 readers where the automated tests have identified the condition was not met.
As next steps, the individual readers can be updated individually to meet the condition and reincluded in the tests. Once all readers have been updated, the API contract could be updated to clarify the expectation and the relationship between the first file of
getUsedFiles
and the output ofgetCurrentFile
although doing this will likely require a major version increment.