Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirtualImagePlus: Retain B&C settings for each slice #4131

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dgault
Copy link
Member

@dgault dgault commented Dec 15, 2023

This is a follow up to a previous PR https://github.com/ome/bioformats/pull/3850/files and is an attempt to address the issues raised in https://forum.image.sc/t/b-c-for-a-whole-virtual-stack-cont/57811/10

The fix here reapplies the table settings for each slice using the same approach as the ContrastAdjuster. This may be overkill and there may be a simpler solution to ensure that the settings are applied for each slice.

@dgault dgault added this to the 7.2.0 milestone Dec 15, 2023
@dgault
Copy link
Member Author

dgault commented Dec 15, 2023

Failures relate to the 16bit tests, requires further investigation

@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/b-c-for-a-whole-virtual-stack-cont/57811/19

@melissalinkert melissalinkert modified the milestones: 7.2.0, 8.0.0 Jan 29, 2024
@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/b-c-for-a-whole-virtual-stack-cont/57811/21

@sbesson sbesson removed this from the 8.0.0 milestone Sep 2, 2024
@joshmoore
Copy link
Member

Following on from https://forum.image.sc/t/bio-formats-support/101109, it's unclear if there will be capacity to move this PR forward. We've removed it from 8.0.0 for the moment. If anyone is interested in getting involved, please let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants