[messenger] Refactoring Messenger and Requester #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
не дождался мерджа моего PR. Потом rebase сделаю |
смерджил |
alex13sh
changed the title
atatarov
reviewed
Aug 5, 2020
RostovtsevDanila
approved these changes
Aug 5, 2020
atatarov
reviewed
Aug 6, 2020
atatarov
reviewed
Aug 6, 2020
atatarov
reviewed
Aug 7, 2020
atatarov
reviewed
Aug 7, 2020
atatarov
reviewed
Aug 7, 2020
| Messenger::Messenger() | ||
| : m_requester{new Requester(this)} | ||
| { | ||
| connect(m_requester, &Requester::replied, this, &Messenger::handleResponse); | ||
| connect(m_requester, &Requester::error, this, [this](int code) { | ||
| emit error(fromErrorCode(code)); |
There was a problem hiding this comment.
можешь обосновать чем такая конструкция fromErrorCode лучше той что была?
atatarov
reviewed
Aug 7, 2020
| @@ -25,17 +25,26 @@ class Requester : public QObject | |||
| PUT, | |||
| DELETE | |||
| }; | |||
| enum MessengerError { | |||
| OtherError, | |||
| NoNetworkConnect, | |||
There was a problem hiding this comment.
Поищи пожалуйста все места где используется NoNetworkConnect чтобы избежать того, что его использование где-то поломалось
There was a problem hiding this comment.
Да и это я про enum в messenger.h написал, не заметил сразу что у тебя в двух местах перечисление обхявляется
atatarov
reviewed
Aug 7, 2020
| signals: | ||
| void error(MessengerError errorType); | ||
| void userIdChanged(QString userId); | ||
|
|
||
| private slots: | ||
| void handleResponse(QNetworkReply *reply); // Общий для всех ответов | ||
| void handleResponse(Requester::ApiType api, const QByteArray &data); // Общий для всех ответов |
There was a problem hiding this comment.
можешь пожалуйста комментарий перевести на англ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Рефакторинг Messenger и Requester. И добавил get запрос.