Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake] Add option to specify a dependency is test only #192

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

filippobrizzi
Copy link
Collaborator

Description

To improve modularity and reduce dependencies, I added an option to specify that a module is a test dependency only.
In this way, when building with BUILD_TESTING=OFF we can speed things up and reduce coupling.

To showcase the improvement I updated the unit test of the bag module:

  • Remove the custom proto and instead use dummy_type
  • Make types_proto and random test only dependency

Copy link
Collaborator

@floriantschopp floriantschopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niice

@filippobrizzi filippobrizzi merged commit 4832503 into main Oct 29, 2024
5 checks passed
@filippobrizzi filippobrizzi deleted the cmake_test_dependency branch October 29, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants