Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Move toString into utils. #177

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Conversation

lhruby
Copy link
Collaborator

@lhruby lhruby commented Sep 27, 2024

Description

Move toString into utils. This solves the issue that modules like serdes::protobuf would depend on types, which in turn creates cyclic dependencies.

A move to fmt::format_as is not included and will be implemented in a follow up.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • If this is a new component I have added examples.
  • I updated the README and related documentation.

@lhruby lhruby enabled auto-merge (squash) September 27, 2024 15:12
@lhruby lhruby merged commit 21b95c3 into main Sep 27, 2024
3 checks passed
@lhruby lhruby deleted the fix/move-to-string-into-utils-string branch September 27, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants