Fix: improve protobuf concept (#39)

# Description Cleanup `ProtobufSerializable` concept.
olympus-robotics · Apr 2, 2024 · 77f82e1 · 77f82e1
1 parent ad57535
commit 77f82e1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 11 deletions.
diff --git a/modules/serdes/include/hephaestus/serdes/protobuf/concepts.h b/modules/serdes/include/hephaestus/serdes/protobuf/concepts.h
@@ -9,9 +9,7 @@
 namespace heph::serdes::protobuf {
 
 template <class T>
-struct ProtoAssociation {
-  using Type = void;
-};
+struct ProtoAssociation {};
 
 template <typename T>
 concept ProtobufMessage = requires(T proto, void* out_data, const void* in_data, int size) {

diff --git a/modules/serdes/include/hephaestus/serdes/serdes.h b/modules/serdes/include/hephaestus/serdes/serdes.h
@@ -11,11 +11,7 @@
 namespace heph::serdes {
 
 template <class T>
-concept ProtobufSerializable = requires(T data) {
-  { !std::is_same_v<typename protobuf::ProtoAssociation<T>::Type, void> };
-};
-
-// ProtoAssociation<T>::Type
+concept ProtobufSerializable = protobuf::ProtobufMessage<typename protobuf::ProtoAssociation<T>::Type>;
 
 template <class T>
 [[nodiscard]] auto serialize(const T& data) -> std::vector<std::byte>;

diff --git a/modules/utils/src/version_impl.h b/modules/utils/src/version_impl.h
@@ -17,8 +17,8 @@ static constexpr std::uint8_t VERSION_MAJOR = 0;
 static constexpr std::uint8_t VERSION_MINOR = 0;
 static constexpr std::uint16_t VERSION_PATCH = 1;
 
-static constexpr std::string_view REPO_BRANCH = "feature/spinner";
-static constexpr std::string_view BUILD_PROFILE = "RelWithDebInfo";
-static constexpr std::string_view REPO_HASH = "6b4f737";
+static constexpr std::string_view REPO_BRANCH = "fix/proto_concept";
+static constexpr std::string_view BUILD_PROFILE = "Release";
+static constexpr std::string_view REPO_HASH = "900c283";
 
 } // namespace heph::utils