Use deepmerge package for merging dicts #442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behavior of the configure_tools function is the same as before. The extract_tool_options function now tries to merge the edam dicts. But if a merge conflict occurs, an exception is thrown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the deepmerge package for merging dicts. This also provides a simple solution for #431. I used the merge_or_raise merger for merging edam files. This merger raises an Exception if no merging is possible.
Behavior for the other merges is the same as before.
I also tested this with deepmerge version 0.0.5, which is available in the ubuntu 20.04 repository. So this should be backwards compatible to older python versions.