FLOW-700 | FLOW-604 | FLOW-799 | New Features and Improvements in f-div and f-tag #110
Conversation
* divider addition * divider test addition * changes * divider usage story added * changes * changes * changes * changes scss * changes
# @cldcvr/flow-core ## [1.17.5] - 2023-07-05 ### Bug Fixes - `f-search`: `scope` dropdown width updated. - disabled css updated for elements in shadowRoot. <hr/> # @cldcvr/flow-table ## [1.1.0] - 2023-07-11 ### Features - `f-table-schema` : Search on a specific column ### Improvements - Action in the cell requires id (in case of displaying popover) - Disable row selection for a specific rows - Hide sort on a specific columns ### Bug Fixes - Sort doesn’t work if we have the search term - Highlight row not changing the background of the sticky column
* FLOW-821 md editor package added * FLOW-821 WIP : md editor updated * FLOW-821 WIP: md editor css changes * FLOW-821 input event added + css updated * FLOW-821 tests added * FLOW-821 hooks updated
…elect (#109) * 108 search-input event added in f-select * 108 search-input event updated in f-select
|
@mayankfulera: Adding label Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Kudos, SonarCloud Quality Gate passed!
|
.storybook/storybook.css
Outdated
| @@ -356,3 +356,13 @@ input[type="color"]::-webkit-color-swatch { | |||
| align-items: center; | |||
| flex: 1 0 auto; | |||
| } | |||
|
|
|||
| .f-div-highlight-overlay { | |||
There was a problem hiding this comment.
storybook.css is specific for stroybook then why we added this here? we can add this in f-root.scss
| changedProperties: PropertyValueMap<any> | Map<PropertyKey, unknown> | ||
| ): Promise<void> { | ||
| super.updated(changedProperties); | ||
| requestAnimationFrame(() => { |
There was a problem hiding this comment.
requestAnimationFrame will execute on every re-paint of the browser, remove it.
just check the character count of this.label in a render function and add tooltip attribute based on that
| @@ -222,7 +231,8 @@ export class FTag extends FRoot { | |||
| "left-icon": true, | |||
| ...iconClasses, | |||
| "f-tag-system-icon": this.tagSystemIcon ? true : false, | |||
| "system-icon-size": this.size === "small" ? true : false | |||
| "system-icon-size": this.size === "small" ? true : false, | |||
| "f-tag-small-emoji": this.size === "small" ? true : false | |||
There was a problem hiding this comment.
can't we do overflow:hidden on f-tag itself
|
@mayankfulera: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Checklist for raising a PR
Describe your PR
Features
f-div:highlightproperty added to highlight a particular f-div and others would be in overlay.Improvements
f-tag: added ellipsis according to the width of parent and on its own.Bug Fixes
f-tag: emoji wasn't taking the correct size according to the f-tag size.Add additional question here
YesNoNA