Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when loading ignores files that are not text files. #1332

Conversation

AlexBCa
Copy link
Contributor

@AlexBCa AlexBCa commented Oct 19, 2024

This contribution fixes issue #1323.

In this small change, an exception is handled if the file cannot be opened because it is not a text file; it simply ignores it and loads the project.

This is my first contribution to the project, and I wanted to do something simple, although I have ideas for refactoring the project loading to make it more robust. If you are open to some refactoring, I would appreciate any feedback so I can get started, knowing what is currently being sought in the project.

@TheJackiMonster TheJackiMonster added this to the 0.17.0 milestone Oct 20, 2024
@TheJackiMonster
Copy link
Collaborator

Sounds good to me. Theoretically I've already started on a separate branch to make bigger changes to the IO code. You can find it here:

Also I think most details about the changes I made so far can be read in issue #1117. So feel free to look into it and change or improve it. I'd also be happy to see someone try porting equivalent changes into the Qt code base since my changes only work on the GTK port/branch. But either way making the IO code more reliable is great.

@TheJackiMonster TheJackiMonster merged commit db361f3 into olivierkes:develop Oct 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants