Fixed type detection recognizing mixed as a collection

CHANGELOG.md

@@ -12,6 +12,7 @@
 ### Removed
 
 ### Fixed
+- Fixed type detection recognizing `mixed` as a collection.
 
 ### Security
 

gradle.properties

@@ -3,7 +3,7 @@
 
 pluginGroup = dev.nybroe.collector
 pluginName_ = Collector
-pluginVersion = 0.0.1-EAP.12
+pluginVersion = 0.0.1-EAP.13
 pluginSinceBuild = 202
 pluginUntilBuild =
 

src/main/kotlin/dev/nybroe/collector/Util.kt

@@ -36,5 +36,14 @@ val Function.isShortArrowFunction: Boolean
     get() = FunctionImpl.isShortArrowFunction(this)
 
 fun PhpType.isCollection(project: Project): Boolean {
-    return collectionType.isConvertibleFrom(this, PhpIndex.getInstance(project))
+    val filteredType = this.filterMixed()
+
+    if (filteredType.isEmpty) {
+        return false
+    }
+
+    return collectionType.isConvertibleFrom(
+        filteredType,
+        PhpIndex.getInstance(project)
+    )
 }

src/test/kotlin/dev/nybroe/collector/inspections/CollectFunctionOnCollectionInspectionTest.kt

@@ -17,4 +17,8 @@ internal class CollectFunctionOnCollectionInspectionTest : InspectionTest() {
     fun testCollectOnEloquentCollectVariable() {
         doTest("collect_on_eloquent_collect_variable")
     }
+
+    fun testCollectOnMixedVariable() {
+        doNotMatchTest("collect_on_mixed_variable")
+    }
 }

src/test/resources/inspections/CollectFunctionInCollectionInspection/nonMatches/collect_on_mixed_variable.php

@@ -0,0 +1,6 @@
+<?php
+
+/** @var mixed|array $var */
+$var = [];
+
+collect($var);