Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document minimum Bazel version #17

Merged
merged 1 commit into from
Jun 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 32 additions & 7 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,26 +47,51 @@ jobs:
strategy:
fail-fast: false
matrix:
include:
- example: default
- example: format-binary
- example: format-config
- example: format-ignore
example:
- default
- format-binary
- format-config
- format-ignore
steps:
- uses: actions/checkout@v4
- shell: bash
run: |
cd example/${{ matrix.example }}

bazel build --config=clang-format-fix

bazel build --config=clang-format

bazel-version:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
bazel_version:
- latest
- 7.x
- 6.x
- 5.x
steps:
- uses: actions/checkout@v4
- shell: bash
env:
USE_BAZEL_VERSION: ${{ matrix.bazel_version }}
run: |
cd example/default

version=${{ matrix.bazel_version }}

if [[ "$version" == latest || "$version" < 7 ]]; then
sed -i '/enable_bzlmod/d' .bazelrc
fi

bazel build --config=clang-format-fix

all:
runs-on: ubuntu-latest
if: ${{ github.base_ref == 'main' }}
needs:
- check-format
- fix-format
- bazel-version
steps:
- run: true
5 changes: 1 addition & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,5 @@ build:clang-format-base --@bazel_clang_format//:ignore=//:clang-format-ignore

## Requirements

- Bazel ???
- Bazel 5.x
- ClangFormat 14

I'm not sure what the minimum versions are but please let me know if you are
using a version that doesn't work.