fix formatting of files in place #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverlee
force-pushed
the
I90d6c95e921d6ab9565bfe5318635901d3de8ad1
branch
3 times, most recently
from
f36e347
to
d6adaa9
Compare
miklelappo
approved these changes
Jun 28, 2024
This commit renames and redefines the `clang_format_aspect` to take `clang-format` options and execution requirements. It also defines a fix aspect which modifies files in place with `clang-format`, removing the need for an update script and subsequent need to determine the `bazel` process. resolves #5 Change-Id: I90d6c95e921d6ab9565bfe5318635901d3de8ad1
oliverlee
force-pushed
the
I90d6c95e921d6ab9565bfe5318635901d3de8ad1
branch
from
d6adaa9
to
2655fa3
Compare
miklelappo
reviewed
Jun 28, 2024
| command = """ | ||
| set -euo pipefail | ||
|
|
||
| test -e .clang-format || ln -s -f {config} .clang-format |
There was a problem hiding this comment.
3rd party should really avoid doing any symlinks especially using -f flag. Clang-tidy supports clang-format -style=file:<path/to/config/file> ... notation since 14.0.0.
For example one can do:
clang-format -style=file:/home/username/projects/someproject/.clang-format -i main.cpp
Would you fix that it might worth to mention minimal clang-format version on README site
There was a problem hiding this comment.
I forgot that sandboxing is disabled with the new fix aspect. Sorry!
There was a problem hiding this comment.
No problem :-) Should be very straightforward to fix that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit renames and redefines the
clang_format_aspectto takeclang-formatoptions and execution requirements. It also defines a fixaspect which modifies files in place with
clang-format, removing theneed for an update script and subsequent need to determine the
bazelprocess.
resolves #5
Change-Id: I90d6c95e921d6ab9565bfe5318635901d3de8ad1