Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Containerize semonitor #3

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Containerize semonitor #3

merged 3 commits into from
Jun 20, 2023

Commits on Jun 20, 2023

  1. resolve symlinks for serial ports 

    It is not uncommon to setup smart symlinks for hotpluggable/USB
adapters, so they always have a known name. PySerial however seems to
refuse to follow symlinks

Signed-off-by: Olliver Schinagl <[email protected]>
    @oliv3r
    oliv3r committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    0e27650 View commit details
    Browse the repository at this point in the history

  2. se/msg: Be a little bit more carefull with the hardcoded path 

    The path replacement function tries to remove `/se` from the full path.
However, if the path already contains `/se`, such as for example in
`/solaredge/semonitor/se/msg.py` the path gets completely messed up.

Instead, by using python's `removesuffix`, we get what we wanted.

Signed-off-by: Olliver Schinagl <[email protected]>
    @oliv3r
    oliv3r committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    77bfc3e View commit details
    Browse the repository at this point in the history

  3. Containerize semonitor 

    To be able to track dependencies better, make development easier and
have a more reliable means of distributing and managing semonitor, it is
good to put it isolate it within a container.

Everything should still be useable as before, but care needs to be taken
when running pipelines, as if these are not properly passed into the
container, one is piping the outside of the container. The result would
be the same, but either two docker instances would need to be run or the
second command needs to be available on the host. Both are not ideal
solutions.

Signed-off-by: Olliver Schinagl <[email protected]>
    @oliv3r
    oliv3r committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    162a956 View commit details
    Browse the repository at this point in the history