forked from reactos/reactos
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[DESK] _countof and rc-trivia (reactos#7298)
- use _countof() consistently throughout the module instead of mixed ARRAYSIZE/countof. In *.rc: - the 3 AUTORADIOBUTTONS should not end with dots. In Windows 2k3sp2 ARB do never end with dots, I double-checked that here also in desk.cpl - all 3 ARB should have an accel. I added the german ones, and added FIXMEs where I didn't know the correct accels - the GROUPBOX IDC_SCREENS_DUMMY2 should not have an accel, but the only button in there PUSHBUTTON IDC_SCREENS_POWER_BUTTON should have an accel. This fixes a few existing accel collisions, e.g. in nl-NL.rc - add a few additional FIXMEs for missing accels where I stumbled over them (most of them I fixed by guessing in the older branches, but I think it makes sense to let the actual native speakers fix them with the same accel that would be used in the 2k3sp2-version of *their* language) - ro-RO.rc: Fix the forbidden characters according to the romanian-translation-rules I noticed those glitches while porting back stuff, and acted on the FIXMEs in the backport instead of just fingerpointing to them (what I did on master).
- Loading branch information
1 parent
7774a24
commit 945e856
Showing
32 changed files
with
540 additions
and
557 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,9 @@ | ||
/* | ||
* COPYRIGHT: See COPYING in the top level directory | ||
* PROJECT: ReactOS Display Control Panel | ||
* FILE: dll/cpl/desk/effappdlg.c | ||
* PURPOSE: Effects appearance dialog | ||
* | ||
* PROGRAMMERS: Jan Roeloffzen (jroeloffzen[at]hotmail[dot]com) | ||
* Ismael Ferreras Morezuelas ([email protected]) | ||
* PROGRAMMERS: Jan Roeloffzen <[email protected]> | ||
* Ismael Ferreras Morezuelas <[email protected]> | ||
*/ | ||
|
||
#include "desk.h" | ||
|
@@ -70,7 +68,7 @@ AddToCombobox(INT Combo, HWND hwndDlg, INT From, INT To) | |
|
||
for (iElement = From; iElement <= To; iElement++) | ||
{ | ||
LoadString(hApplet, iElement, (LPTSTR)tstrText, ARRAYSIZE(tstrText)); | ||
LoadString(hApplet, iElement, (LPTSTR)tstrText, _countof(tstrText)); | ||
SendDlgItemMessage(hwndDlg, Combo, CB_ADDSTRING, 0, (LPARAM)tstrText); | ||
} | ||
} | ||
|
@@ -164,9 +162,7 @@ EffAppearanceDlgProc(HWND hwndDlg, UINT uMsg, WPARAM wParam, LPARAM lParam) | |
case IDC_EFFAPPEARANCE_KEYBOARDCUES: | ||
case IDC_EFFAPPEARANCE_FLATMENUS: | ||
if (HIWORD(wParam) == BN_CLICKED) | ||
{ | ||
EffAppearanceDlgUpdateControls(hwndDlg, g); | ||
} | ||
break; | ||
|
||
case IDC_EFFAPPEARANCE_ANIMATIONTYPE: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.