[BROWSEUI] SHExplorerParseCmdLine: Fix parsing of /root (reactos#6752)

Remove excessive (!pInfo->pidlPath) check in SHExplorerParseCmdLine function. JIRA issue: CORE-16939
oleg-dubinskiy · Apr 15, 2024 · 1b85a5f · 1b85a5f
1 parent ea34ecc
commit 1b85a5f
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/dll/win32/browseui/parsecmdline.cpp b/dll/win32/browseui/parsecmdline.cpp
@@ -252,9 +252,8 @@ SHExplorerParseCmdLine(_Out_ PEXPLORER_CMDLINE_PARSE_RESULTS pInfo)
 
     PCWSTR strNextArg = _FindFirstField(strFieldArray);
 
-    BOOL hasNext = TRUE;
+    BOOL hasNext = _ReadNextArg(&strNextArg, strField, _countof(strField));
 
-    hasNext = _ReadNextArg(&strNextArg, strField, _countof(strField));
     while (TRUE)
     {
         // Basic flags-only params first
@@ -319,9 +318,6 @@ SHExplorerParseCmdLine(_Out_ PEXPLORER_CMDLINE_PARSE_RESULTS pInfo)
 
             TRACE("CmdLine Parser: Found %S flag\n", strField);
 
-            if (!pInfo->pidlPath)
-                return FALSE;
-
             if (!hasNext)
                 return FALSE;
 
@@ -414,7 +410,6 @@ SHExplorerParseCmdLine(_Out_ PEXPLORER_CMDLINE_PARSE_RESULTS pInfo)
                         TRACE("CmdLine Parser: Parsed target path. dwFlags=%08lx, strPath=%S\n", pInfo->dwFlags, field);
                     }
                 }
-
             }
         }