[Design] Improve Jarbas document page legibility #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello guys! It's been a while that this PR has been opened. Is there something from the PR process I'm missing here? Can I do anything to help the merge? :) |
|
Hi @mauehara. We haven't tested its implementation yet. It was very important that you sent this message. Thank you! |
|
@mauehara I tested its implementation. No inconsistencies regarding responsiveness or dependencies were identified. |
sergiomario
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this Pull Request?
Based on some observations in #421 and some of my own, this Pull Request intend to enhance the overall legibility of the document page in Jarbas.
What was done to achieve this purpose?
How to test if it really works?
Just go to a document page :) Got before/after screenshots here too
BEFORE
AFTER
Who can help reviewing it?
Everyone :)
ps: This is my first pull request for an open source project ever :)