Properly handle failed downloads

ofek · May 14, 2024 · 720cea0 · 720cea0
1 parent 90091ba
commit 720cea0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/docs/changelog.md b/docs/changelog.md
@@ -8,6 +8,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ## Unreleased
 
+***Fixed:***
+
+- Properly handle failed downloads
+
 ## 0.20.0 - 2024-05-13
 
 ***Added:***

diff --git a/src/network.rs b/src/network.rs
@@ -1,6 +1,6 @@
 use std::io::Write;
 
-use anyhow::{Context, Result};
+use anyhow::{bail, Context, Result};
 
 use crate::terminal;
 
@@ -15,5 +15,9 @@ pub fn download(url: &String, writer: impl Write, description: &str) -> Result<(
     response.copy_to(&mut pb.wrap_write(writer))?;
     pb.finish_and_clear();
 
-    Ok(())
+    if response.status().is_success() {
+        Ok(())
+    } else {
+        bail!("download failed: {}, {}", response.status(), url)
+    }
 }