[REM] theme_common, theme_*: remove theme_common #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theme_*: theme_bewise, theme_enark, theme_graphene, theme_treehouse This commit copies the `theme_common` mixins in the few places where they are used, to prepare for the future deletion of `theme_common`. task-3696867
This commit removes the old snippets across all themes. task-3696867
This commit removes old compatibility assets from all themes. task-3696867
Since no mixin is used anymore, the file can be deleted. task-3696867
This commit removes static files that are not referenced from an asset, static files which are empty or only contain comments and `primary_variables.scss` which only a never referenced variable. task-3696867
This commit removes the whole mechanism about specifying the `o-color-palette-number` through assets. It can still be done in the custom SCSS. task-3696867
Theme common used to contain tools that were reused by most of the themes. It has now become an empty module which pollutes the module dependency tree. This commit removes `theme_common` and adapts themes that used to depend on it. task-3696867
bso-odoo
force-pushed
the
master-no_theme_common-bso
branch
from
61f17b2
to
db495eb
Compare
|
Related upgrade PR: https://github.com/odoo/upgrade/pull/5906 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theme common used to contain tools that were reused by most of the themes. It has now become an empty module which pollutes the module dependency tree.
This commit removes
theme_commonand adapts themes that used to depend on it.task-3696867