[REM] theme_*: remove useless scss variable overrides #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guillaume-gdi
force-pushed
the
master-remove-useless-design-data-gdi
branch
from
86c1198
to
d86a556
Compare
xO-Tx
suggested changes
Mar 14, 2024
There was a problem hiding this comment.
@Guillaume-gdi small tweaks before r+ 👍
MYSCR(x) => Maybe You Should Consider Removing x 😉.
This commit removes the overrides of scss variables that are set to the default value and duplicated overrides. task-2463604
Guillaume-gdi
force-pushed
the
master-remove-useless-design-data-gdi
branch
from
d86a556
to
33765a8
Compare
|
Thank your for the great review @xO-Tx! I adapted the PR ✔️ |
|
@Guillaume-gdi thanks for the update (and for removing the other overrides of |
robodoo
pushed a commit
that referenced
this pull request
Mar 15, 2024
This commit removes the overrides of scss variables that are set to the default value and duplicated overrides. task-2463604 closes #768 Signed-off-by: Outagant Mehdi (mou) <[email protected]>
xlu-odoo
pushed a commit
to odoo-dev/design-themes
that referenced
this pull request
Jun 21, 2024
This commit removes the overrides of scss variables that are set to the default value and duplicated overrides. task-2463604 closes odoo#768 Signed-off-by: Outagant Mehdi (mou) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the overrides of scss variables that are set to the default value.
task-2463604
We do this in a separate PR to facilitate this other PR.