Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Silon - Staging.15.0 #659

Open
wants to merge 2 commits into
base: 15.0
Choose a base branch
from
Open

Conversation

MarioAbad
Copy link

No description provided.

robodoo and others added 2 commits May 25, 2023 09:34
uniquifier: +muSKhrBCR6R6AFv
For-Commit-Id: 56a04f3
Runbot-dependency: odoo/odoo:4fa2dbcaf777c23758519ab0feb9707a7592cd6b
Runbot-dependency: odoo/enterprise:cf025c7f43f6c341c668a07969a5776bf04f9be8
@MarioAbad MarioAbad changed the title Staging.15.0 Theme Silon - Staging.15.0 May 26, 2023
@robodoo
Copy link
Collaborator

robodoo commented May 26, 2023

This PR targets the un-managed branch odoo/design-themes:staging.15.0, it needs to be retargeted before it can be merged.

@rdeodoo rdeodoo changed the base branch from staging.15.0 to 15.0 May 26, 2023 16:42
@robodoo
Copy link
Collaborator

robodoo commented May 26, 2023

Copy link
Contributor

@rdeodoo rdeodoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

I think you selected the wrong target (staging.15.0), I changed it to 15.0.

Here are a few unorganized feedbacks:

  • We won't introduce new themes in 15.0. Arguably 16.0 or saas 16.X could be considerate candidate, but master is surely the way to go.
  • It's unlikely that we will introduce a community theme in our codebase for now. We have been working the past years on the website and themes so the community is able to create easily themes. We have still a few ongoing tasks to facilitate that process for Odoo 17.
    So, we are happy to see people working on themes ! But it's too soon and it won't probably fit in our own codebase.
  • We don't yet have themes related to the ecommerce directly, especially not with python code. It doesn't really work with our theme selection screen which is showing all themes. In your case, a website only (not ecommerce) database would see your theme and by selecting it, it will most likely install the ecommerce app which is not what they want.
    What you want to do is probably create a theme only related to the website, and have a bridge module adding stuff into this theme with a dependency of your theme and the sale/blog/whatever module you want to improve.
  • Themes should ideally be only about style and feature-less, which is not the case here as there is many python code.
  • I just scrolled quickly but I don't think your theme is multi website friendly/compliant, which is a really important thing regarding themes. I've seen act windows, list views etc, those are not multi website compliant.
    You can have a look by creating a second website on a second domain, your theme should only impact the website where you installed it.

Everything I am telling you here is about having a theme in Odoo codebase. It does not apply to the Odoo app stores where your theme would fit 👍

Finally, I am not sure if you have seen it, but a theme documentation was released very recently, it might help: https://www.odoo.com/documentation/15.0/developer/howtos/website_themes.html

Anyway, good job, that's a lot of work here 👍

cc @qsm-odoo @Cocographique @pierre-pde

@rdeodoo rdeodoo mentioned this pull request May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants