fixup! [IMP] html_editor: convert table of content to an embedded com… #3455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…was done after the component was destroyed
This commit adds the embedded_component_env resource management inside the embedded component plugin
Embedded components such as a table of contents should also be mounted to be used in readonly. This commit extracts the minimal mount logic from the embedded component plugin and put it in the HtmlViewer in order to do so.
…html_editor: keep wysiwyg when saving content with JSON attrs Before this commit, editing an html field containing at least one element with one attribute with a JSON string as its value and then saving caused a rebuild of the Wysiwyg and therefore the creation of a new editor, inducing flickering and multiple reloadings (i.e. embedded components). Reason: Server side, the html string value is stored without html entities. In frontend, the html string value extracted from the editor is done through `innerHTML`, and therefore contains html entities. In `_commitChanges`, two values with different formats could be compared and were therefore always different if at least one HTML entity was present. Solution: Add a `decodeHTMLEntities` util which should be used when comparing values extracted from the DOM through `innerHTML` and html values coming from the server.
This commit is part of the big refactoring project to convert every Knowledge commands and behaviors to the new html_editor. This here adds the /draw command as standard inside the editor, so that it can be used anywhere. task-4061015
|
This PR targets the un-managed branch odoo-dev/odoo:master-knowledge-html-editor, it needs to be retargeted before it can be merged. |
abd-msyukyu-odoo
force-pushed
the
master-knowledge-html-editor
branch
7 times, most recently
from
53975fa
to
d52f5ac
Compare
abd-msyukyu-odoo
force-pushed
the
master-knowledge-html-editor
branch
26 times, most recently
from
fbc5507
to
880402b
Compare
abd-msyukyu-odoo
force-pushed
the
master-knowledge-html-editor
branch
3 times, most recently
from
d992fae
to
9851067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ponent