refactor: replace NodeJS internal module imports with node: specifi…

…er imports
octokit · Nov 26, 2023 · eb7b9c1 · eb7b9c1
1 parent 8423803
commit eb7b9c1
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 5 deletions.
diff --git a/scripts/generate-types.ts b/scripts/generate-types.ts
diff --git a/src/middleware/node/get-missing-headers.ts b/src/middleware/node/get-missing-headers.ts
@@ -1,6 +1,6 @@
 // remove type imports from http for Deno compatibility
 // see https://github.com/octokit/octokit.js/issues/24#issuecomment-817361886
-// import { IncomingMessage } from "http";
+// import { IncomingMessage } from "node:http";
 type IncomingMessage = any;
 
 const WEBHOOK_HEADERS = [

diff --git a/src/middleware/node/get-payload.ts b/src/middleware/node/get-payload.ts
@@ -3,7 +3,7 @@ import AggregateError from "aggregate-error";
 
 // remove type imports from http for Deno compatibility
 // see https://github.com/octokit/octokit.js/issues/24#issuecomment-817361886
-// import { IncomingMessage } from "http";
+// import { IncomingMessage } from "node:http";
 // declare module "http" {
 //   interface IncomingMessage {
 //     body?: WebhookEvent | unknown;

diff --git a/src/middleware/node/middleware.ts b/src/middleware/node/middleware.ts
@@ -1,6 +1,6 @@
 // remove type imports from http for Deno compatibility
 // see https://github.com/octokit/octokit.js/issues/2075#issuecomment-817361886
-// import { IncomingMessage, ServerResponse } from "http";
+// import { IncomingMessage, ServerResponse } from "node:http";
 type IncomingMessage = any;
 type ServerResponse = any;
 

diff --git a/src/middleware/node/on-unhandled-request-default.ts b/src/middleware/node/on-unhandled-request-default.ts
@@ -1,6 +1,6 @@
 // remove type imports from http for Deno compatibility
 // see https://github.com/octokit/octokit.js/issues/24#issuecomment-817361886
-// import { IncomingMessage, ServerResponse } from "http";
+// import { IncomingMessage, ServerResponse } from "node:http";
 type IncomingMessage = any;
 type ServerResponse = any;
 

diff --git a/test/typescript-validate.ts b/test/typescript-validate.ts
@@ -5,7 +5,7 @@ import {
   WebhookError,
   createNodeMiddleware,
 } from "../src/index.ts";
-import { createServer } from "http";
+import { createServer } from "node:http";
 import type {
   HandlerFunction,
   RemoveHandlerFunction,