fix: handle invalid JSON in payload

octokit · Sep 13, 2018 · 4c7a3a6 · 4c7a3a6
1 parent d48a53f
commit 4c7a3a6
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/middleware/middleware.js b/middleware/middleware.js
@@ -50,12 +50,21 @@ function middleware (state, request, response, next) {
   })
 
   request.on('end', () => {
-    const payload = Buffer.concat(dataChunks).toString()
+    const data = Buffer.concat(dataChunks).toString()
+    let payload
+
+    try {
+      payload = JSON.parse(data)
+    } catch (error) {
+      response.statusCode = 400
+      response.end('Invalid JSON')
+      return
+    }
 
     verifyAndReceive(state, {
       id: id,
       name: eventName,
-      payload: JSON.parse(payload),
+      payload,
       signature
     })