Added readonly to fields that are never modified (#2759)

Co-authored-by: Lehonti Ramos <john@doe> Co-authored-by: Keegan Campbell <[email protected]>
octokit · Aug 11, 2023 · d46527d · d46527d
1 parent 6ab43b2
commit d46527d
Show file tree

Hide file tree

Showing 29 changed files with 166 additions and 166 deletions.
diff --git a/Octokit.Reactive/Clients/ObservableGitHubAppInstallationsClient.cs b/Octokit.Reactive/Clients/ObservableGitHubAppInstallationsClient.cs
@@ -11,7 +11,7 @@ namespace Octokit.Reactive
     /// </remarks>
     public class ObservableGitHubAppInstallationsClient : IObservableGitHubAppInstallationsClient
     {
-        private IGitHubAppInstallationsClient _client;
+        private readonly IGitHubAppInstallationsClient _client;
         private readonly IConnection _connection;
 
         public ObservableGitHubAppInstallationsClient(IGitHubClient client)

diff --git a/Octokit.Reactive/Clients/ObservableGitHubAppsClient.cs b/Octokit.Reactive/Clients/ObservableGitHubAppsClient.cs
@@ -12,7 +12,7 @@ namespace Octokit.Reactive
     /// </remarks>
     public class ObservableGitHubAppsClient : IObservableGitHubAppsClient
     {
-        private IGitHubAppsClient _client;
+        private readonly IGitHubAppsClient _client;
         private readonly IConnection _connection;
 
         public ObservableGitHubAppsClient(IGitHubClient client)

diff --git a/Octokit.Reactive/ObservableCodespacesClient.cs b/Octokit.Reactive/ObservableCodespacesClient.cs
@@ -5,8 +5,8 @@ namespace Octokit.Reactive
 {
     public class ObservableCodespacesClient : IObservableCodespacesClient
     {
-        private ICodespacesClient _client;
-        private IConnection _connection;
+        private readonly ICodespacesClient _client;
+        private readonly IConnection _connection;
 
         public ObservableCodespacesClient(IGitHubClient githubClient)
         {

diff --git a/Octokit.Tests.Integration/Clients/CheckRunsClientTests.cs b/Octokit.Tests.Integration/Clients/CheckRunsClientTests.cs
@@ -10,8 +10,8 @@ public class CheckRunsClientTests
     {
         public class TheCreateMethod
         {
-            IGitHubClient _github;
-            IGitHubClient _githubAppInstallation;
+            readonly IGitHubClient _github;
+            readonly IGitHubClient _githubAppInstallation;
 
             public TheCreateMethod()
             {
@@ -68,8 +68,8 @@ public async Task CreatesCheckRunWithRepositoryId()
 
         public class TheUpdateMethod
         {
-            IGitHubClient _github;
-            IGitHubClient _githubAppInstallation;
+            readonly IGitHubClient _github;
+            readonly IGitHubClient _githubAppInstallation;
 
             public TheUpdateMethod()
             {
@@ -146,8 +146,8 @@ public async Task UpdatesCheckRunWithRepositoryId()
 
         public class TheGetAllForReferenceMethod
         {
-            IGitHubClient _github;
-            IGitHubClient _githubAppInstallation;
+            readonly IGitHubClient _github;
+            readonly IGitHubClient _githubAppInstallation;
 
             public TheGetAllForReferenceMethod()
             {
@@ -230,8 +230,8 @@ public async Task GetsAllCheckRunsWithRepositoryId()
 
         public class TheGetAllForCheckSuiteMethod
         {
-            IGitHubClient _github;
-            IGitHubClient _githubAppInstallation;
+            readonly IGitHubClient _github;
+            readonly IGitHubClient _githubAppInstallation;
 
             public TheGetAllForCheckSuiteMethod()
             {
@@ -315,8 +315,8 @@ public async Task GetsAllCheckRunsWithRepositoryId()
 
         public class TheGetMethod
         {
-            IGitHubClient _github;
-            IGitHubClient _githubAppInstallation;
+            readonly IGitHubClient _github;
+            readonly IGitHubClient _githubAppInstallation;
 
             public TheGetMethod()
             {
@@ -383,8 +383,8 @@ public async Task GetsCheckRunWithRepositoryId()
 
         public class TheGetAllAnnotationsMethod
         {
-            IGitHubClient _github;
-            IGitHubClient _githubAppInstallation;
+            readonly IGitHubClient _github;
+            readonly IGitHubClient _githubAppInstallation;
 
             public TheGetAllAnnotationsMethod()
             {

diff --git a/Octokit.Tests.Integration/Clients/CheckSuitesClientTests.cs b/Octokit.Tests.Integration/Clients/CheckSuitesClientTests.cs
@@ -9,8 +9,8 @@ public class CheckSuitesClientTests
     {
         public class TheGetMethod
         {
-            IGitHubClient _github;
-            IGitHubClient _githubAppInstallation;
+            readonly IGitHubClient _github;
+            readonly IGitHubClient _githubAppInstallation;
 
             public TheGetMethod()
             {
@@ -59,8 +59,8 @@ public async Task GetsCheckSuiteWithRepositoryId()
 
         public class TheGetAllForReferenceMethod
         {
-            IGitHubClient _github;
-            IGitHubClient _githubAppInstallation;
+            readonly IGitHubClient _github;
+            readonly IGitHubClient _githubAppInstallation;
 
             public TheGetAllForReferenceMethod()
             {
@@ -107,8 +107,8 @@ public async Task GetsAllCheckSuitesWithRepositoryId()
 
         public class TheUpdatePreferencesMethod
         {
-            IGitHubClient _github;
-            IGitHubClient _githubAppInstallation;
+            readonly IGitHubClient _github;
+            readonly IGitHubClient _githubAppInstallation;
 
             public TheUpdatePreferencesMethod()
             {
@@ -155,8 +155,8 @@ public async Task UpdatesPreferencesWithRepositoryId()
 
         public class TheCreateMethod
         {
-            IGitHubClient _github;
-            IGitHubClient _githubAppInstallation;
+            readonly IGitHubClient _github;
+            readonly IGitHubClient _githubAppInstallation;
 
             public TheCreateMethod()
             {
@@ -215,8 +215,8 @@ public async Task CreatesCheckSuiteWithRepositoryId()
 
         public class TheRerequestMethod
         {
-            IGitHubClient _github;
-            IGitHubClient _githubAppInstallation;
+            readonly IGitHubClient _github;
+            readonly IGitHubClient _githubAppInstallation;
 
             public TheRerequestMethod()
             {

diff --git a/Octokit.Tests.Integration/Clients/GitHubAppInstallationsClientTests.cs b/Octokit.Tests.Integration/Clients/GitHubAppInstallationsClientTests.cs
@@ -8,7 +8,7 @@ public class GitHubAppInstallationsClientTests
     {
         public class TheGetAllRepositoriesForCurrentMethod
         {
-            IGitHubClient _github;
+            readonly IGitHubClient _github;
 
             public TheGetAllRepositoriesForCurrentMethod()
             {
@@ -28,7 +28,7 @@ public async Task GetsAllRepositories()
 
         public class TheGetAllRepositoriesForCurrentUserMethod
         {
-            IGitHubClient _github;
+            readonly IGitHubClient _github;
 
             public TheGetAllRepositoriesForCurrentUserMethod()
             {

diff --git a/Octokit.Tests.Integration/Clients/GitHubAppsClientTests.cs b/Octokit.Tests.Integration/Clients/GitHubAppsClientTests.cs
@@ -9,7 +9,7 @@ public class GitHubAppsClientTests
     {
         public class TheGetMethod
         {
-            IGitHubClient _github;
+            readonly IGitHubClient _github;
 
             public TheGetMethod()
             {
@@ -31,7 +31,7 @@ public async Task GetsApp()
 
         public class TheGetCurrentMethod
         {
-            IGitHubClient _github;
+            readonly IGitHubClient _github;
 
             public TheGetCurrentMethod()
             {
@@ -53,7 +53,7 @@ public async Task GetsCurrentApp()
 
         public class TheGetAllInstallationsForCurrentMethod
         {
-            IGitHubClient _github;
+            readonly IGitHubClient _github;
 
             public TheGetAllInstallationsForCurrentMethod()
             {
@@ -80,7 +80,7 @@ public async Task GetsAllInstallations()
 
         public class TheGetInstallationForCurrentMethod
         {
-            IGitHubClient _github;
+            readonly IGitHubClient _github;
 
             public TheGetInstallationForCurrentMethod()
             {
@@ -109,7 +109,7 @@ public async Task GetsInstallation()
 
         public class TheGetAllInstallationsForCurrentUserMethod
         {
-            IGitHubClient _github;
+            readonly IGitHubClient _github;
 
             public TheGetAllInstallationsForCurrentUserMethod()
             {
@@ -130,7 +130,7 @@ public async Task GetsAllInstallationsForCurrentUser()
 
         public class TheCreateInstallationTokenMethod
         {
-            IGitHubClient _github;
+            readonly IGitHubClient _github;
 
             public TheCreateInstallationTokenMethod()
             {
@@ -154,7 +154,7 @@ public async Task CreatesInstallationToken()
 
         public class TheGetOrganizationInstallationForCurrentMethod
         {
-            IGitHubClient _github;
+            readonly IGitHubClient _github;
 
             public TheGetOrganizationInstallationForCurrentMethod()
             {
@@ -173,8 +173,8 @@ public async Task GetsOrganizationInstallations()
 
         public class TheGetRepositoryInstallationForCurrentMethod
         {
-            IGitHubClient _github;
-            IGitHubClient _githubAppInstallation;
+            readonly IGitHubClient _github;
+            readonly IGitHubClient _githubAppInstallation;
 
             public TheGetRepositoryInstallationForCurrentMethod()
             {
@@ -214,7 +214,7 @@ public async Task GetsRepositoryInstallationsWithRepositoryId()
 
         public class TheGetUserInstallationForCurrentMethod
         {
-            IGitHubClient _github;
+            readonly IGitHubClient _github;
 
             public TheGetUserInstallationForCurrentMethod()
             {

diff --git a/Octokit.Tests.Integration/Clients/MigrationsClientTests.cs b/Octokit.Tests.Integration/Clients/MigrationsClientTests.cs
@@ -11,9 +11,9 @@
 public class MigrationsClientTests : IDisposable
 {
     private readonly IGitHubClient _gitHub;
-    private List<RepositoryContext> _repos;
+    private readonly List<RepositoryContext> _repos;
     private Migration _migrationContext;
-    private string _orgName;
+    private readonly string _orgName;
     private bool isExported = false;
 
     public MigrationsClientTests()

diff --git a/Octokit.Tests.Integration/Clients/OrganizationMembersClientTests.cs b/Octokit.Tests.Integration/Clients/OrganizationMembersClientTests.cs
@@ -9,8 +9,8 @@ public class OrganizationMembersClientTests
     {
         public class TheGetAllMethod
         {
-            private IGitHubClient _gitHub;
-            private string _organizationFixture;
+            private readonly IGitHubClient _gitHub;
+            private readonly string _organizationFixture;
 
             public TheGetAllMethod()
             {
@@ -296,7 +296,7 @@ public async Task ReturnsNoFailedInvitations()
 
         public class TheGetAllOrganizationMembershipsForCurrentMethod
         {
-            private IGitHubClient _gitHub;
+            private readonly IGitHubClient _gitHub;
 
             public TheGetAllOrganizationMembershipsForCurrentMethod()
             {

diff --git a/Octokit.Tests.Integration/Clients/ProjectCardsClientTests.cs b/Octokit.Tests.Integration/Clients/ProjectCardsClientTests.cs
@@ -9,8 +9,8 @@ public class ProjectCardsClientTests
 {
     public class TheGetAllMethod : IDisposable
     {
-        IGitHubClient _github;
-        RepositoryContext _context;
+        readonly IGitHubClient _github;
+        readonly RepositoryContext _context;
 
         public TheGetAllMethod()
         {
@@ -164,8 +164,8 @@ public void Dispose()
 
     public class TheGetMethod : IDisposable
     {
-        IGitHubClient _github;
-        RepositoryContext _context;
+        readonly IGitHubClient _github;
+        readonly RepositoryContext _context;
 
         public TheGetMethod()
         {
@@ -196,8 +196,8 @@ public void Dispose()
 
     public class TheCreateMethod : IDisposable
     {
-        IGitHubClient _github;
-        RepositoryContext _context;
+        readonly IGitHubClient _github;
+        readonly RepositoryContext _context;
 
         public TheCreateMethod()
         {
@@ -252,8 +252,8 @@ public void Dispose()
 
     public class TheUpdateMethod : IDisposable
     {
-        IGitHubClient _github;
-        RepositoryContext _context;
+        readonly IGitHubClient _github;
+        readonly RepositoryContext _context;
 
         public TheUpdateMethod()
         {
@@ -325,8 +325,8 @@ public void Dispose()
 
     public class TheDeleteMethod : IDisposable
     {
-        IGitHubClient _github;
-        RepositoryContext _context;
+        readonly IGitHubClient _github;
+        readonly RepositoryContext _context;
 
         public TheDeleteMethod()
         {
@@ -357,8 +357,8 @@ public void Dispose()
 
     public class TheMoveMethod : IDisposable
     {
-        IGitHubClient _github;
-        RepositoryContext _context;
+        readonly IGitHubClient _github;
+        readonly RepositoryContext _context;
 
         public TheMoveMethod()
         {