Skip to content

Commit

Permalink
Correct type of DeploymentStatus.Id to be 64-bit
Browse files Browse the repository at this point in the history
  • Loading branch information
Cyberboss committed Jun 30, 2023
1 parent ad74468 commit 50e592d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Octokit.Tests/Models/DeploymentStatusTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public void CanDeserialize64BitId()

var actual = new SimpleJsonSerializer().Deserialize<DeploymentStatus>(json);

Assert.Equal<long>(2151661540, actual.Id);
Assert.Equal(2151661540, actual.Id);
Assert.Equal("https://api.github.com/repos/tgstation/TerraGov-Marine-Corps/deployments/965900823/statuses/2151661540", actual.Url);
Assert.Equal(DeploymentState.InProgress, actual.State);
Assert.Null(actual.Payload);
Expand Down
4 changes: 2 additions & 2 deletions Octokit/Models/Response/DeploymentStatus.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public class DeploymentStatus
{
public DeploymentStatus() { }

public DeploymentStatus(int id, string nodeId, string url, DeploymentState state, User creator, IReadOnlyDictionary<string, string> payload, string targetUrl, string logUrl, string environmentUrl, DateTimeOffset createdAt, DateTimeOffset updatedAt, string description)
public DeploymentStatus(long id, string nodeId, string url, DeploymentState state, User creator, IReadOnlyDictionary<string, string> payload, string targetUrl, string logUrl, string environmentUrl, DateTimeOffset createdAt, DateTimeOffset updatedAt, string description)
{
Id = id;
NodeId = nodeId;
Expand All @@ -30,7 +30,7 @@ public DeploymentStatus(int id, string nodeId, string url, DeploymentState state
/// <summary>
/// Id of this deployment status.
/// </summary>
public int Id { get; private set; }
public long Id { get; private set; }

/// <summary>
/// GraphQL Node Id
Expand Down

0 comments on commit 50e592d

Please sign in to comment.