Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Upgrade .gitignore to latest #325

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

Lamparter
Copy link
Contributor

Removed a few ignores such as the '.nupkg' ignore since this would conflict with the NuGet package in the 'lib' directory


Before the change?

  • .gitignore was the visual studio ignore at the time of project initialisation

After the change?

This is a pretty minor code quality change but it's good to update files like these to future-proof the repo and prevent any accidents.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Removed a few ignores such as the '.nupkg' ignore since this would conflict with the NuGet package in the 'lib' directory

Signed-off-by: Lamparter <[email protected]>
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

.gitignore Outdated Show resolved Hide resolved
@nickfloyd
Copy link
Contributor

Thanks for this change... would you also mind updating actions/upload-artifact to v3 or v4 in dotnetcore.yaml to get CI ✅

@0x5bfa
Copy link
Contributor

0x5bfa commented Sep 19, 2024

would you also mind updating actions/upload-artifact to v3 or v4 in dotnetcore.yaml to get CI ✅

Fyi, I did this in other pr. The pr that contains the move to src dir.
Anyways it won't conflict.

@Lamparter
Copy link
Contributor Author

Lamparter commented Sep 19, 2024

Yeah I think @nickfloyd just means they want to see the build result here 😅

@nickfloyd nickfloyd added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR dependencies Pull requests that update a dependency file labels Sep 19, 2024
@nickfloyd nickfloyd merged commit ccdd213 into octokit:main Sep 19, 2024
1 check passed
@Lamparter Lamparter deleted the ignore branch September 19, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants