Update dependencies and cleanup projects #304
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update test projects from .NET Core 3.1 (out of support) to .NET 6 (LTS)
* Remove `<Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />` (see microsoft/vstest#472 (comment))
* Remove `<LangVersion>7.2</LangVersion>` on test projects
* Fix `Run_Specifies_Cancellation_Token` which (rightfully) throws when running on .NET 6
|
I'm interested in picking this up, as I'm looking at #312 but also want to update other aspects of the library. To avoid stomping on your branch/fork any further, I'll create a separate PR. |
|
@Lamparter i think we've already worked this in our PR right? |
Yes I think so. I definitely did do 1st (obviously) and I remember fixing the 4th task also. But not sure whether or not I implemented 2nd and 3rd.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />(see Test projects end up with this GUID microsoft/vstest#472 (comment))<LangVersion>7.2</LangVersion>on test projectsRun_Specifies_Cancellation_Tokenwhich (rightfully) throws when running on .NET 6