Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): replace @gr2m/fetch-mock with fetch-mock #415

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Conversation

wolfy1339
Copy link
Member


Before the change?

  • Used a custom fork of fetch-mock for Fetch API support

After the change?

  • Use the fetch-mock module again, it has been updated to support the Fetch API

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jul 2, 2024
Copy link

github-actions bot commented Jul 2, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 enabled auto-merge (squash) July 12, 2024 17:18
@Uzlopak
Copy link
Contributor

Uzlopak commented Jul 13, 2024

@wolfy1339

Why dont you merge it?

@wolfy1339
Copy link
Member Author

There's a merge conflict, and I haven't gotten around to fixing it

@Uzlopak
Copy link
Contributor

Uzlopak commented Jul 14, 2024

Should I create a new PR so that you can approve it and merge it?

@wolfy1339 wolfy1339 merged commit 0f713c7 into main Jul 15, 2024
7 checks passed
@wolfy1339 wolfy1339 deleted the fetch-mock-v10 branch July 15, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants