chore(deps): update dependency @octokit/tsconfig to v2 (#426)

* chore(deps): update dependency @octokit/tsconfig to v2 * Add test tsconfig * Import types to fix build * npm run lint:fix --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Keegan Campbell <[email protected]>
octokit · Jun 16, 2023 · 315c188 · 315c188
1 parent ddccc1a
commit 315c188
Show file tree

Hide file tree

Showing 11 changed files with 50 additions and 25 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -27,7 +27,7 @@
     "@octokit/webhooks": "^10.0.0"
   },
   "devDependencies": {
-    "@octokit/tsconfig": "^1.0.2",
+    "@octokit/tsconfig": "^2.0.0",
     "@types/jest": "^29.0.0",
     "@types/node": "^18.0.0",
     "@types/node-fetch": "^2.5.8",
@@ -47,7 +47,14 @@
     "node": ">= 14"
   },
   "jest": {
-    "preset": "ts-jest",
+    "transform": {
+      "^.+\\.(ts|tsx)$": [
+        "ts-jest",
+        {
+          "tsconfig": "test/tsconfig.test.json"
+        }
+      ]
+    },
     "testEnvironment": "node",
     "coverageThreshold": {
       "global": {

diff --git a/src/each-installation.ts b/src/each-installation.ts
@@ -2,7 +2,10 @@ import { composePaginateRest } from "@octokit/plugin-paginate-rest";
 import { Octokit } from "@octokit/core";
 
 import { App } from "./index";
-import { EachInstallationFunction, EachInstallationInterface } from "./types";
+import type {
+  EachInstallationFunction,
+  EachInstallationInterface,
+} from "./types";
 import { getInstallationOctokit } from "./get-installation-octokit";
 
 export function eachInstallationFactory(app: App) {

diff --git a/src/each-repository.ts b/src/each-repository.ts
@@ -2,7 +2,7 @@ import { composePaginateRest } from "@octokit/plugin-paginate-rest";
 import { Octokit } from "@octokit/core";
 
 import { App } from "./index";
-import {
+import type {
   EachRepositoryFunction,
   EachRepositoryInterface,
   EachRepositoryQuery,

diff --git a/src/index.ts b/src/index.ts
@@ -3,7 +3,7 @@ import { createAppAuth } from "@octokit/auth-app";
 import { OAuthApp } from "@octokit/oauth-app";
 import { Webhooks } from "@octokit/webhooks";
 
-import {
+import type {
   Options,
   ConstructorOptions,
   EachInstallationInterface,

diff --git a/src/middleware/node/index.ts b/src/middleware/node/index.ts
@@ -9,7 +9,7 @@ import { createNodeMiddleware as webhooksNodeMiddleware } from "@octokit/webhook
 
 import { App } from "../../index";
 import { onUnhandledRequestDefault } from "./on-unhandled-request-default";
-import { Options } from "../../types";
+import type { Options } from "../../types";
 
 export type MiddlewareOptions = {
   pathPrefix?: string;

diff --git a/src/types.ts b/src/types.ts
@@ -1,5 +1,5 @@
 import { Octokit } from "@octokit/core";
-import { Endpoints } from "@octokit/types";
+import type { Endpoints } from "@octokit/types";
 
 export type Options = {
   appId?: number | string;

diff --git a/src/webhooks.ts b/src/webhooks.ts
@@ -1,9 +1,9 @@
 import { Octokit } from "@octokit/core";
 import { createAppAuth } from "@octokit/auth-app";
 import { createUnauthenticatedAuth } from "@octokit/auth-unauthenticated";
-import { Webhooks, EmitterWebhookEvent } from "@octokit/webhooks";
+import { Webhooks, type EmitterWebhookEvent } from "@octokit/webhooks";
 
-import { Options } from "./types";
+import type { Options } from "./types";
 
 export function webhooks(
   appOctokit: Octokit,

diff --git a/test/tsconfig.json b/test/tsconfig.json
diff --git a/test/tsconfig.test.json b/test/tsconfig.test.json
@@ -0,0 +1,9 @@
+{
+  "extends": "../tsconfig.json",
+  "compilerOptions": {
+    "emitDeclarationOnly": false,
+    "noEmit": true,
+    "verbatimModuleSyntax": false
+  },
+  "include": ["src/**/*"]
+}
diff --git a/tsconfig.json b/tsconfig.json
@@ -7,5 +7,7 @@
     "emitDeclarationOnly": true,
     "sourceMap": true
   },
-  "include": ["src/**/*"]
+  "include": [
+    "src/**/*"
+  ]
 }