Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade @octokit/core #83

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix: upgrade @octokit/core #83

merged 1 commit into from
Apr 9, 2024

Conversation

wolfy1339
Copy link
Contributor

Fixes #81

It seems that @octokit/core was upgraded and the engines field in this package wasn't

BREAKING CHANGE: require NodeJS >= 18

@wolfy1339
Copy link
Contributor Author

#76 and #80 will need to be reverted for 4.x and a new major release cut, if we want to follow semantic versioning

gr2m
gr2m approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for all your help ❤️

@gr2m
Copy link
Member

gr2m commented Apr 9, 2024

#76 and #80 will need to be reverted for 4.x and a new major release cut, if we want to follow semantic versioning

honestly unless someone complaints, i'd just do a breaking release now

@gr2m gr2m merged commit 2a1ee1d into octoherd:main Apr 9, 2024
1 check passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@oscard0m
Copy link
Member

oscard0m commented Apr 9, 2024

Thanks for being on top of this @wolfy1339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Types for Octokit instance broken
3 participants
@wolfy1339 @gr2m @oscard0m