Component/creation-bouton #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olyn-octo
reviewed
Jun 26, 2024
src/stories/Button.stories.ts
Outdated
| @@ -10,6 +10,7 @@ const meta = { | |||
| tags: ['autodocs'], | |||
| argTypes: { | |||
| size: { control: 'select', options: ['small', 'medium', 'large'] }, | |||
| type: { options: ['primary', 'seondary', 'destructive'] }, | |||
olyn-octo
reviewed
Jun 26, 2024
src/stories/Button.stories.ts
Outdated
| @@ -10,6 +10,7 @@ const meta = { | |||
| tags: ['autodocs'], | |||
| argTypes: { | |||
| size: { control: 'select', options: ['small', 'medium', 'large'] }, | |||
| type: { options: ['primary', 'seondary', 'destructive'] }, | |||
| backgroundColor: { control: 'color' }, | |||
There was a problem hiding this comment.
supprimer background color et tous les arg qui sont encore dans la story mais pas ds le composant
olyn-octo
reviewed
Jun 26, 2024
src/stories/Button.vue
Outdated
| </template> | ||
|
|
||
| <script lang="ts" setup> | ||
| <script lang="ts"setup> |
There was a problem hiding this comment.
remettre espace entre ts" et setup
olyn-octo
reviewed
Jun 26, 2024
src/stories/Button.vue
Outdated
| */ | ||
| primary?: boolean, | ||
| type ?: 'primary'| 'secondary' | 'destructive', |
olyn-octo
reviewed
Jun 26, 2024
src/stories/Button.vue
Outdated
| /** | ||
| * The label of the button | ||
| */ | ||
| label: string, | ||
| /** | ||
| * primary or secondary button | ||
| * type of the button |
There was a problem hiding this comment.
Suggested change
| * type of the button | |
| * button type* |
olyn-octo
reviewed
Jun 26, 2024
src/stories/button.css
Outdated
|
|
||
| .storybook-button--secondary:hover { | ||
| border: 2px solid var(--color-button-border-secondary-hover); | ||
| box-shadow: 2px 4px 7px 2px rgb(from var(--color-button-shadow-primary) r g b / 30%); |
There was a problem hiding this comment.
ne pas oublier de creer variable : -color-button-shadow-secondary
olyn-octo
reviewed
Jun 26, 2024
src/stories/button.css
Outdated
| .storybook-button--destructive { | ||
| background-color:var(--color-button-background-destructive); | ||
| border: 1px solid var(--color-button-border-destructive); | ||
| color: #FFF; |
olyn-octo
reviewed
Jun 26, 2024
src/stories/button.css
Outdated
| background-color: var(--color-button-background-destructive); | ||
| border-color: var(--color-button-background-destructive); | ||
| box-shadow: 2px 4px 7px 2px var(--color-button-shadow-destructive); | ||
| /*remplacer par des tokens de couleurs pour la shadow ou pas ?*/ |
olyn-octo
reviewed
Jun 26, 2024
src/tokens/colors.css
Outdated
| --color-button-shadow-secondary-active: var(--color-navy-500); | ||
|
|
||
|
|
||
| --color-button-text-destructive:#FFF; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.