Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change reload behavior to use current url #504

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

remyzorg
Copy link

@remyzorg remyzorg commented May 3, 2018

No description provided.

@remyzorg remyzorg changed the title change reload behavior to use current url Change reload behavior to use current url May 3, 2018
@remyzorg remyzorg added the WIP label May 3, 2018
@remyzorg
Copy link
Author

remyzorg commented May 3, 2018

It seems my pull request breaks some reloads... So we should not merge this now. I'll work on it further.

@balat
Copy link
Member

balat commented Jun 28, 2019

I think this is hazardous as it breaks Eliom's service logic.
I would prefer to understand first in which cases current solution does not work.
We can probably fix them ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants