Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for stricter checking in GCC 14 #1004

Merged
merged 1 commit into from
May 3, 2024

Conversation

jamesjer
Copy link
Contributor

@jamesjer jamesjer commented Dec 2, 2023

GCC 14 will be stricter about such things as implicit function return types, implicit conversions between pointers and integers, and mismatched pointer types. Some warnings will become errors. The Fedora project is preparing for these changes:

The lwt package fails to build with the test compiler mentioned in those links. The main symptom is missing features due to a gcc run that ends with an error, even though the feature is present. The cause is mostly implicit conversions between pointers and integers. In addition, due to header streamlining, errno.h is no longer implicitly included in unix_getprotoby_getservby_job.c, so include it explicitly.

I await the results of the CI run with fear and trepidation.

@raphael-proust
Copy link
Collaborator

Thanks for the contribution and for the detailed explanations. I don't have the bandwidth to check this in depth rn. I'll try to get to it at some point.

@raphael-proust
Copy link
Collaborator

Ok I had a better look. I didn't notice at first that the bulk of the changes are on the discovery script. The changes seem ok to me. I'll merge unless someone has an objection soon.

@smorimoto
Copy link
Member

@MisterDA Do you have any ideas?

@MisterDA
Copy link
Contributor

MisterDA commented May 2, 2024

Can't look at this for the next two weeks.

@smorimoto
Copy link
Member

Totally fine to me!

@raphael-proust raphael-proust merged commit 2d27668 into ocsigen:master May 3, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants