Runtime: safe fixes #1678
Merged
Runtime: safe fixes #1678
+81
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review |
hhugo
reviewed
Sep 19, 2024
hhugo
reviewed
Sep 19, 2024
hhugo
reviewed
Sep 19, 2024
hhugo
reviewed
Sep 19, 2024
hhugo
reviewed
Sep 19, 2024
smorimoto
force-pushed
the
fix-safe-stuff
branch
2 times, most recently
from
7ef3ef9
to
034024f
Compare
smorimoto
force-pushed
the
fix-safe-stuff
branch
from
034024f
to
384075e
Compare
|
@hhugo I think we can move this forward. I'm planning to introduce benchmarks before the next PR. Are you positive about that? |
|
Regarding the review process, can you try to close conversation on if there is a clear consensus |
smorimoto
force-pushed
the
fix-safe-stuff
branch
from
384075e
to
12af300
Compare
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
smorimoto
force-pushed
the
fix-safe-stuff
branch
from
12af300
to
4da74d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these fixes are very general, independent of the JS runtime version.