Use File-Based Catalog Format #45
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: varad-ahirwadkar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
varad-ahirwadkar
force-pushed
the
main
branch
from
0e13150
to
4619bef
Compare
varad-ahirwadkar
force-pushed
the
main
branch
from
4619bef
to
be1bbaa
Compare
|
It was failing to build the catalog image for |
varad-ahirwadkar
force-pushed
the
main
branch
from
be1bbaa
to
9219129
Compare
| $(OPM) render $(BUNDLE_IMGS) >> $(TMP_DIR)/rsct-operator-catalog.json | ||
| $(OPM) generate dockerfile $(TMP_DIR) -i quay.io/operator-framework/opm:${OPM_VERSION} | ||
| ## Apending Final stage for ppc64le | ||
| echo "FROM quay.io/operator-framework/opm:$(OPM_VERSION)-ppc64le" >> $(TMP_DIR).Dockerfile |
There was a problem hiding this comment.
you can include this line into the below Dockerfile_final_stage docker file itself and use ARG for replacing VERSION substitution
There was a problem hiding this comment.
I tried that approach, but it doesn't work because the ARG gets declared in the first stage and isn't accessible in the second stage.
There was a problem hiding this comment.
can you adopt this --platform=linux/ppc64le instead of -ppc64le? long term solution - lets see if we can work with OPM team to generate the Dockerfile itself to support any target architecture(enhance generate command)
There was a problem hiding this comment.
I have tried using --platform=linux/ppc64le, it works locally but in workflow it pull x86 image.
There was a problem hiding this comment.
long term solution - lets see if we can work with OPM team to generate the Dockerfile itself to support any target architecture(enhance generate command)
sure
| $(OPM) render $(BUNDLE_IMGS) >> $(TMP_DIR)/rsct-operator-catalog.json | ||
| $(OPM) generate dockerfile $(TMP_DIR) -i quay.io/operator-framework/opm:${OPM_VERSION} | ||
| ## Apending Final stage for ppc64le | ||
| echo "FROM quay.io/operator-framework/opm:$(OPM_VERSION)-ppc64le" >> $(TMP_DIR).Dockerfile |
There was a problem hiding this comment.
can you adopt this --platform=linux/ppc64le instead of -ppc64le? long term solution - lets see if we can work with OPM team to generate the Dockerfile itself to support any target architecture(enhance generate command)
This PR fixes: #27