Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: start OB server and run all tests #82

Closed
wants to merge 1 commit into from

Conversation

tisonkun
Copy link

Try to run all tests in CI.

@tisonkun
Copy link
Author

cc @jiacai2050

@jiacai2050
Copy link
Contributor

@IHEII Please have a review.

@IHEII
Copy link
Contributor

IHEII commented Oct 23, 2023

Thanks to @tisonkun.
We are now considering adding CI to all our projects. Actually, the Rust client may be a project that adds CI later for four reasons:

  1. We could not implement an OceanBase Server in GitHub Docker now. (We are trying to provide a slim OB Server in docker, still in progress ref)
  2. ConfigUrl used to connect to the server is unstable now. (In progress)
  3. The Slim OB Server in Docker mentioned above is 4.x, which is incompatible with our client now(only works in 3.x, which means we will use more time to fix it)
  4. Tests should be adapted to CI

@IHEII
Copy link
Contributor

IHEII commented Jan 12, 2024

Hi @tisonkun, I think it is time to restart ci now. Because we have implemented docker for the observer and we have already supported 4.x observer now.
I tested observer docker in Java client a month ago oceanbase/obkv-table-client-java#68. And CI works well on Java client right now (https://github.com/oceanbase/obkv-table-client-java/pull/75/checks).
Could you help to implement a CI check on the rust client? All we need to do is to run the docker(like testcontainers in Java, and parameters are in here) and try to run tests in tests/. For convenience, we may select some basic tests for CI.

@tisonkun
Copy link
Author

Closed as I don't have time and energy to nudge this PR.

@tisonkun tisonkun closed this Jun 21, 2024
@tisonkun tisonkun deleted the patch-1 branch June 21, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants