-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More functionnalities for repl #951
Open
OscarLahaie
wants to merge
23
commits into
ocamllabs:master
Choose a base branch
from
OscarLahaie:better-repl
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
262d495
Evaluate file
OscarLahaie 331577c
Preserve focus
OscarLahaie 4d769f8
Remove location message
OscarLahaie 9f3e328
get_code -> get_selected_code
OscarLahaie d0e0bbd
prepare_code -> preformat_code
OscarLahaie 880864c
Wrapping Ast Node support
OscarLahaie bcc8dc3
evaluate-selection -> evaluate-expression
OscarLahaie 76736da
better preformat
OscarLahaie 5612c5b
Update path request and usage
OscarLahaie eb22999
Name change : _evaluate_selection -> _evaluate_expression
OscarLahaie fc62f64
Fix the position of cursor send to lsp-server
OscarLahaie 9c2802b
Infinity loop fix
OscarLahaie 76dffe6
Add comments case
OscarLahaie c7b99ea
Fix top call problem
OscarLahaie 9581a42
Cursor jump after expressions evaluations
OscarLahaie 8d1ca2d
Readme update
OscarLahaie 0e0c694
Now handles comments between expressions
OscarLahaie 6a363ca
Better end file behavior
OscarLahaie 17952b7
remove article
e762957
rename commands specifying that evaluation happens in REPL
8f4c068
make fmt
005ef00
* reveal new selection when cursor jumps;
1b9c5b6
some more cleanup
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we preserve
ocaml.evaluate-selection
? I don't see anything wrong with having both commands.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the new command evaluates the selection if there's one; otherwise, it evaluates a (module-level) let or module binding depending which comes first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understood. I just don't see why we should remove a command with a clear name and semantics and replace it with a command that has neither of those things. Seems like we're just irritating users who are used to the old command this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, but then I would show a deprecation message saying to use the new command because