-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change logo and name #458
base: master
Are you sure you want to change the base?
Change logo and name #458
Conversation
3af3a83
to
162b3c6
Compare
Is changing the extension ID from If this repo ever moves to the https://github.com/ocaml organization, maybe we could change the ID to |
I don't think that's the case. The PR I mentioned renamed the extension ID from |
That extension is still listed under
I don't see how it would be possible for the If we're planning to move to the |
That's very strange: https://github.com/hackwaly/vscode-ocaml/pull/124/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R3
Maybe it cross-checks with the VCS URI?
Sure that sounds reasonable |
I worry about directly change ocaml to ocaml-deprecated in package.json just results two published extensions - one is ocaml the other is ocaml-deprecated. So I didn't use ocaml-deprecated to publish. AFAIK. There's no name conflict policy in vscode marketplace. So you can use ocamllabs/ocaml without issue. EDIT: There may be some vsce command to rename extension. Not just change the package.json. But I have no time to find out that. |
That is my guess too. That is also why I don't want to rename
Yeah, I don't think there's any name conflict right now. My worry is about the user experience of switching the ID: if it causes two published extension or stops the extension from updating. |
162b3c6
to
82f619b
Compare
I don't think we should wait for the move of the repository to merge this anymore, so I reverted the name change, and this PR now only updates the displayed name and the logo. Ready to merge when approved. |
The extension is still being featured on the extensions page: https://marketplace.visualstudio.com/vscode @smorimoto: any thoughts? |
There should be no problem to change the logo, but I don't know the name. If it can be handled as another extension, you should be very careful about that. If something goes wrong, there's nothing to gain and everything to lose. |
Honestly, I don't really think icon and name are blocking adoption right now. In the case of F#, Ionide is the most popular one, but I have never decided not to use it by name, and no one around me has made such a decision. Maybe the best way is to promote it enough in a diffusive medium like OCaml's Twitter account. I doubt the logo and name are really a problem. |
Closing for now, as it seems a bit stale. I guess we can revisit when (if) we move the repo to the OCaml org. |
Re-opening the PR - let's coordinate the rebranding and move to the OCaml organisation. What's blocking the transfer of the repository to
Moving the extension to an official publish for OCaml can be done separately and will need assistance from the VSCode support, so let's do this as a second step. |
82f619b
to
eb27091
Compare
eb27091
to
8336b83
Compare
src/extension_consts.ml
Outdated
@@ -56,8 +56,8 @@ module Commands = struct | |||
|
|||
let open_ocamllsp_output = ocaml_prefixed "open-ocamllsp-output" | |||
|
|||
let open_ocaml_platform_ext_output = | |||
ocaml_prefixed "open-ocaml-platform-ext-output" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess if users have associated a keybinding to it, it is yes. It's a pretty niche use case I feel, but if you feel we shouldn't change the ID I'll revert this
d9069ed
to
62d65e9
Compare
62d65e9
to
5740a5f
Compare
This PR addresses part of the concerns raised in #457:
For the second point, the name currently collides with @hackwaly's extension, but he agreed to deprecate it in favor of this one, so if hackwaly/vscode-ocaml#124 is merged with the name update, that won't be a problem anymore.
Merge blocked by the PR above, and a new release of hackwaly/vscode-ocaml.