-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batteries-3.7.1 #24414
batteries-3.7.1 #24414
Conversation
supersedes #24327 |
Co-authored-by: Marcello Seri <[email protected]>
I am completely OK to remove parallelization of the tests. |
I was not even happy that I had to retag batteries: it works, we ship. |
To me, if the package compiles and install successfully, this is enough in terms of package testing. |
jobs {!with-test} | ||
1 {with-test} | ||
"@install" | ||
"@runtest" {with-test} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"@runtest" {with-test} |
The fix worked for this release. I think there is value in testing on multiple archs, oses and versions of the compiler, but if next time you don't want to bother you can disable the tests in the releases by removing the corresponding call from the opam file
I am re-running some revdeps, but the failure were infrastructural so I plan to merge soon |
Now also the lint is happy. The remaining failures are unrelated |
No description provided.