Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batteries-3.7.1 #24414

Merged
merged 6 commits into from
Sep 15, 2023
Merged

batteries-3.7.1 #24414

merged 6 commits into from
Sep 15, 2023

Conversation

UnixJunkie
Copy link
Contributor

No description provided.

@UnixJunkie
Copy link
Contributor Author

supersedes #24327

@UnixJunkie
Copy link
Contributor Author

I am completely OK to remove parallelization of the tests.
This is starting to be fairly annoying if the CI tests don't behave as developers' computers...

@UnixJunkie
Copy link
Contributor Author

I was not even happy that I had to retag batteries: it works, we ship.

@UnixJunkie
Copy link
Contributor Author

To me, if the package compiles and install successfully, this is enough in terms of package testing.
Bonus points if we can known if it breaks reverse dependencies.
The test suite is a developers' thing (make test -> dune runtest; I am not even sure if it parallelize things).

jobs {!with-test}
1 {with-test}
"@install"
"@runtest" {with-test}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@runtest" {with-test}

The fix worked for this release. I think there is value in testing on multiple archs, oses and versions of the compiler, but if next time you don't want to bother you can disable the tests in the releases by removing the corresponding call from the opam file

@mseri
Copy link
Member

mseri commented Sep 14, 2023

I am re-running some revdeps, but the failure were infrastructural so I plan to merge soon

@mseri
Copy link
Member

mseri commented Sep 15, 2023

Now also the lint is happy. The remaining failures are unrelated

@mseri mseri merged commit c4137ec into ocaml:master Sep 15, 2023
@UnixJunkie UnixJunkie deleted the batteries_371 branch September 17, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants