[new release] tar, tar-unix and tar-mirage (2.5.1) #23967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES: - Treat headers with link indicator '0' or '\000' (`Normal`) as directories for backward compatibility (reported in mirage/ocaml-tar#129, fix by @reynir)
|
The test failure on Mac is not fatal. I have a fix in mirage/ocaml-tar@95bd151 - not sure if I should re-publish the package with that patch. |
|
If you already have a fix, it would be nice to have the fixed version so that we can leave the tests on without affecting the logs |
mseri
reviewed
Jun 21, 2023
| jobs | ||
| "--promote-install-files=false" | ||
| "@install" | ||
| "@runtest" {with-test} |
There was a problem hiding this comment.
Suggested change
| "@runtest" {with-test} | |
| "@runtest" {with-test & os != "macos"} |
Otherwise I would suggest to disable the tests on macos
|
Ok, thank you for the feedback. I will resubmit with the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decode and encode tar format files in pure OCaml
CHANGES:
Normal) as directories for backward compatibility (reported in Tar.Header.Header.unmarshal should treatNormalentries with trailing slash name asDirectory. mirage/ocaml-tar#129, fix by @reynir)